Skip to content

Commit 11ef522

Browse files
fix: no need to use ipify API (backport #3054) (#3055)
* fix: no need to use ipify API (#3054) (cherry picked from commit 1140750) # Conflicts: # india_compliance/gst_india/api_classes/taxpayer_base.py * fix: conflict --------- Co-authored-by: Sagar Vora <[email protected]>
1 parent 69e303d commit 11ef522

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

india_compliance/gst_india/api_classes/base.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -283,10 +283,6 @@ def mask_sensitive_info(self, log):
283283
request_body[key] = placeholder
284284

285285

286-
def get_public_ip():
287-
return requests.get("https://api.ipify.org").text
288-
289-
290286
def check_scheduler_status():
291287
"""
292288
Throw an error if scheduler is disabled

india_compliance/gst_india/api_classes/taxpayer_base.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from frappe import _
99
from frappe.utils import add_to_date, cint, now_datetime
1010

11-
from india_compliance.gst_india.api_classes.base import BaseAPI, get_public_ip
11+
from india_compliance.gst_india.api_classes.base import BaseAPI
1212
from india_compliance.gst_india.utils import merge_dicts, tar_gz_bytes_to_data
1313
from india_compliance.gst_india.utils.cryptography import (
1414
aes_decrypt_data,
@@ -242,7 +242,6 @@ def setup(self, company_gstin):
242242
"gstin": self.company_gstin,
243243
"state-cd": self.company_gstin[:2],
244244
"username": self.username,
245-
"ip-usr": frappe.cache().hget("public_ip", "public_ip", get_public_ip),
246245
"txn": self.generate_request_id(length=32),
247246
}
248247
)

0 commit comments

Comments
 (0)