-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Sequences be entities #139
Comments
This has been an idea for some time. It would make accessing parts of the sequences a bit easier. Getting to nested sequence zones within the sequence would still require some effort. |
Right now, I'm using the info from the controller entity attributes in my sequence card. I'll comment below the fields I use/consider important to have: - index: 0
name: Diario # important
enabled: true # important
suspended: null # important
status: 'off' # important and could replace the enabled and suspended fields
icon: mdi:stop-circle-outline # important
start: '2023-10-18T22:00:00+02:00' # important, but I would rename it to match zones field next_start (see below)
duration: 2856 # important
adjustment: '%85.0' # important
schedule:
index: 1
name: Tarde
zones: # i only use this to show the number of zones that run on this sequence.
- index: 0
enabled: true
suspended: null
status: 'off'
icon: mdi:stop-circle-outline
duration: 510
adjustment: ''
zone_ids:
- '1'
- index: 1
... In addition to those fields, I will add these:
Also, taken from zones, for consistency:
Also, would you change services to match the behaviour of zones? This is, i.e What do you think? Thanks! |
Thanks for the feedback, it helps to know what you are looking for. There has to be some ground work done to position sequences more as a queue like zones and controllers. It does it at the moment but a bit expensive. I would expect to support services as you suggest, but not perhaps in the first cut. At present service calls that operate on sequences go through the controller but this would be shifted to the sequence entity. |
Here in Spain winter is coming so I already disable irrigation, but I can test new versions as it wouldn't had an impact in maintenance, just let me know in this issue or open a discussion :) Services issue is the least important thing, it's just about consistency between zones and sequences once they both are entities. Thanks! |
The coding is complete for sequence entities but no support for services. Please install from repository and review. Some discussion about attributes is required. Sequences are a list of sequence elements. Each element represents one or more physical zones with additional attributes like duration, delay, repeat etc. Most attributes make sense and are implemented; Further questions and thoughts: Most cards can display attributes but they lack the ability to easily access nested attributes so they have to be flattened out. Perhaps a set of attributes that relate to the active element - which by the way, can be none in the case of the delay between elements - represented by the pause in the sequence status. Maybe the attributes could be prefixed with |
Hi, My "rule of thumb" here would be the physical logical domain of the data. I'll explain my pov along your post.
I guess you migrate the info blow to the new entities, but services are to be called on the controller entity. Not bad on my side, although it would be nice to have.
Totally agree.
Not sure if I understand, but I consider
Both info (sequence overall and current zone) make sense for me. If I'm making a card to show the sequence status, I would like to show overall info about the sequence and the current zone. Main problem I see here is about duplicating info in case it affects HA performance too much.
Not sure about the nested problem, as this cards are really custom and quite complex, I always end up using custom:button-card and i can access all information from there, but I see the point about having it flattened out. Much simpler and opens a wider palette of cards you can use. About the prefixes, I guess you would have:
Funny thing, I hit the delay issue when making a card for a senquence and was quite annoying. The |
Is your feature request related to a problem? Please describe.
When working in a dashboard, if you want to show and control your sequences, it's a lot of work as you have to get data from the attribute in the controller entity. This can't be done without hacking a little bit or using cards like custom:button-card.
Describe the solution you'd like
Make sequences be an entity, just like zones. That way, it's state and info could much easies accessed.
Describe alternatives you've considered
Using templates and custom button-card using the controller as entity just for grabbing sequence info, but you got a lot of unnecessary information and long code just to get some values.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: