Skip to content

Conversation

@yashoza19
Copy link
Collaborator

Pull Request

Description

This commit resolves two issues preventing knowledge bases from being properly linked to agents created from templates:

Problem 1: Incorrect field used for knowledge base IDs

  • Previously used 'name' field (display name like "Commercial Banking Reference")
  • Now correctly uses 'vector_store_name' (LlamaStack identifier like "commercial_banking_kb")

Problem 2: Timing issue with asynchronous ingestion pipeline

  • Agent creation validated KB existence in LlamaStack immediately
  • But ingestion pipeline creates vector stores asynchronously (takes time)
  • Solution: Skip validation for newly created KBs via new skip_kb_validation parameter

The ingestion pipeline still needs to be fixed, @olavtar will open a PR to fix the ingestion pipeline chart version to 0.5.0 after this is merged in.

Related Issue

Fixes #

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactor
  • Docs update
  • Tests

Components Affected

  • Frontend
  • Backend
  • Database
  • Infrastructure

Testing

  • Automated tests added/passing
  • Manual testing done

How Has This Been Tested?

Deployed on dev02 cluster and tested the changes.

Screenshots/Videos (if applicable)

Additional Notes

Is there any additional info that the reviewers should know?

@yashoza19 yashoza19 requested a review from olavtar as a code owner October 17, 2025 18:24
@yashoza19 yashoza19 requested a review from olavtar October 17, 2025 18:57
@olavtar
Copy link
Collaborator

olavtar commented Oct 17, 2025

/lgtm

@olavtar olavtar merged commit c9fed27 into main Oct 17, 2025
5 checks passed
@yuvalturg yuvalturg deleted the fix_agent_template branch October 31, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants