Skip to content

Commit 19442dd

Browse files
committed
refactor(ui): #184 move Dropdown to @codeimage/ui
1 parent 5554c49 commit 19442dd

File tree

12 files changed

+51
-43
lines changed

12 files changed

+51
-43
lines changed

apps/codeimage/src/components/KeyboardShortcuts/KeyboardShortcuts.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
import {createMemo, createSignal, For, from, JSXElement} from 'solid-js';
2-
import {Button, HStack} from '@codeimage/ui';
2+
import {Button, FadeInOutTransition, HStack, PopoverPanel} from '@codeimage/ui';
33
import {HintIcon} from '../Icons/Hint';
44
import {useI18n} from '@codeimage/locale';
55
import {AppLocaleEntries} from '../../i18n';
66
import {Popover, PopoverButton} from 'solid-headless';
7-
import {PopoverPanel} from '../../ui/Dropdown/DropdownMenu';
87
import {useFloating} from '../../core/floating-ui/floating-ui';
98
import * as styles from './KeyboardShortcuts.css';
10-
import {FadeInOutTransition} from '@codeimage/ui';
119
import {offset} from '@floating-ui/dom';
1210
import {PortalHostInjector} from '../../ui/PortalHost/PortalHost';
1311
import * as frame from '@codeimage/store/frame';

apps/codeimage/src/components/ShadowField/ShadowField.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import {Component} from 'solid-js';
22
import {useFloating} from '../../core/floating-ui/floating-ui';
33
import {Popover, PopoverButton} from 'solid-headless';
44
import {sprinkles, textFieldStyles, themeVars} from '@codeimage/ui';
5-
import {DropdownMenu} from '../../ui/Dropdown/DropdownPanel';
6-
import {DropdownPortal} from '../../ui/Dropdown/DropdownPortal';
5+
import {DropdownMenu} from '@codeimage/ui';
6+
import {DropdownPortal} from '@codeimage/ui';
77
import {ShadowForm} from './ShadowForm';
88
import clsx from 'clsx';
99

apps/codeimage/src/components/Terminal/dynamic/DynamicTerminal.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@ import {Dynamic} from 'solid-js/web';
33
import {omitProps} from 'solid-use';
44
import {BaseTerminalProps} from '../TerminalHost';
55
import {appEnvironment} from '../../../core/configuration';
6-
import {Box} from '@codeimage/ui';
6+
import {Box, FadeInOutTransition} from '@codeimage/ui';
77
import * as styles from '../terminal.css';
88
import {CodeImageLogo} from '../../Icons/CodeImageLogo';
9-
import {FadeInOutTransition} from '../../../../../../packages/ui/src/lib/primitives/Transition/Transition';
109

1110
interface DynamicTerminalProps extends BaseTerminalProps {
1211
type: string;

apps/codeimage/src/components/Toolbar/LanguageSelectorButton.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
import {Popover, PopoverButton} from 'solid-headless';
2-
import {Button, FadeInOutTransition} from '@codeimage/ui';
2+
import {
3+
Button,
4+
DropdownItem,
5+
DropdownMenu,
6+
FadeInOutTransition,
7+
} from '@codeimage/ui';
38
import {For} from 'solid-js';
49
import {useFloating} from '../../core/floating-ui/floating-ui';
510
import {offset} from '@floating-ui/dom';
611
import {useI18n} from '@codeimage/locale';
7-
import {DropdownItem} from '../../ui/Dropdown/DropdownItem';
8-
import {DropdownMenu} from '../../ui/Dropdown/DropdownMenu';
912
import {AppLocaleEntries} from '../../i18n';
1013
import {SvgIcon} from '../../ui/SvgIcon/SvgIcon';
1114

apps/codeimage/src/ui/Dropdown/DropdownPanel.tsx

Lines changed: 0 additions & 32 deletions
This file was deleted.

apps/codeimage/src/ui/Dropdown/Dropdown.css.ts renamed to packages/ui/src/lib/primitives/Dropdown/Dropdown.css.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import {style} from '@vanilla-extract/css';
2-
import {buttonStyles, themeVars} from '@codeimage/ui';
2+
import * as buttonStyles from '../Button/Button.css';
3+
import {themeVars} from '../../theme';
34

45
export const dropdownPanel = style({
56
overflow: 'hidden',
File renamed without changes.
File renamed without changes.
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
// type DropdownMenuPanel = PopoverPanelProps<'div'> & {
2+
// title?: string;
3+
// };
4+
//
5+
// export const DropdownMenu: Component<DropdownMenuPanel> = props => {
6+
// return (
7+
// <PopoverPanel
8+
// as={'div'}
9+
// unmount={false}
10+
// class={styles.dropdownPanel}
11+
// {...props}
12+
// >
13+
// <Box display={'flex'} padding={'3'}>
14+
// <Show when={props.title}>
15+
// <Text as={'div'} weight="semibold" size={'sm'}>
16+
// {props.title}
17+
// </Text>
18+
// </Show>
19+
// </Box>
20+
//
21+
// <Menu>
22+
// <MenuItem as={'div'}>{props.children}</MenuItem>
23+
// </Menu>
24+
// </PopoverPanel>
25+
// );
26+
// };

apps/codeimage/src/ui/Dropdown/DropdownPortal.tsx renamed to packages/ui/src/lib/primitives/Dropdown/DropdownPortal.tsx

File renamed without changes.

0 commit comments

Comments
 (0)