Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with end-to-end quoting #25

Open
emschwartz opened this issue Dec 1, 2017 · 4 comments
Open

Incompatible with end-to-end quoting #25

emschwartz opened this issue Dec 1, 2017 · 4 comments

Comments

@emschwartz
Copy link

This plugin is incompatible with end-to-end quoting and other transport layer protocols that make use of error messages, because it does not relay error messages or actually cancel the incoming transfer when rejectIncomingTransfer is called. I don't know if there's a way to solve this without adding a cancellation condition to the rippled escrow transaction and using that to allow the receiver to reject the incoming transfer.

If we decide to drop support for escrow plugins in favor of payment channels, we could decide that this doesn't matter.

@michielbdejong
Copy link
Contributor

FWIW, Amundsen uses this plugin to do the actual prepare and fulfill alongside a BTP connection which takes care of messaging (route broadcasts, vouch, quoting)

@sharafian
Copy link
Contributor

Using a BTP connection alongside XRP escrow means you need a pre-existing relationship though, which makes the plugin bilateral.

I don't think we need to worry about this issue though, because it's already too slow to have a good experience using payments as quotes.

@michielbdejong
Copy link
Contributor

My point of view is that one thing this plugin is very useful for by itself is to pay out a one-off payment to any receiver (exit node). If you want to use it as an entry node then you need the vouch protocol to go over BTP, so for that it's incomplete.

@michielbdejong
Copy link
Contributor

For use in one-to-one relationships you probably almost always want to use a payment channel instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants