From 79892cbb6649504317f6de0c91d75a3d1bd1d0c7 Mon Sep 17 00:00:00 2001
From: pdp2121 <71317875+pdp2121@users.noreply.github.com>
Date: Tue, 25 Feb 2025 11:55:11 -0500
Subject: [PATCH] fix: handle non standard currency with decoded length of 3
 (#1131)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## High Level Overview of Change

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->
Handle non standard currency that decoded to 3 characters, putting
prefix `Fake` to such currency.

Instead of being non-standard, 3 character currency codes should use the
[standard
format](https://xrpl.org/docs/references/protocol/data-types/currency-formats#standard-currency-codes)
if they are not "fake".

### Context of Change

<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?

If there is a design document for this feature, please link it here.
-->
Resolve https://github.com/ripple/explorer/issues/1130

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

## Before / After

<!--
If just refactoring / back-end changes, this can be just an in-English
description of the change at a technical level.
If a UI change, screenshots should be included.
-->

### Before

<img width="941" alt="Screenshot 2025-02-19 at 4 06 15 PM"
src="https://github.com/user-attachments/assets/f7df4ce9-942e-4274-b7ea-39050b976456"
/>

### After

<img width="952" alt="Screenshot 2025-02-19 at 4 07 00 PM"
src="https://github.com/user-attachments/assets/95e46ee3-01c7-425d-a0ca-d2e584eccb76"
/>

---------

Co-authored-by: Elliot Lee <github.public@intelliot.com>
---
 src/containers/shared/components/Currency.tsx           | 9 ++++++++-
 src/containers/shared/components/test/Currency.test.tsx | 7 +++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/src/containers/shared/components/Currency.tsx b/src/containers/shared/components/Currency.tsx
index ac48efa7c..8f72e5a1a 100644
--- a/src/containers/shared/components/Currency.tsx
+++ b/src/containers/shared/components/Currency.tsx
@@ -40,12 +40,19 @@ const Currency = (props: Props) => {
       display
     )
   } else {
-    const currencyCode =
+    let currencyCode =
       currency?.length === NON_STANDARD_CODE_LENGTH &&
       currency?.substring(0, 2) !== LP_TOKEN_IDENTIFIER
         ? hexToString(currency)
         : currency
 
+    if (
+      currency?.length === NON_STANDARD_CODE_LENGTH &&
+      currencyCode.length === 3
+    ) {
+      currencyCode = `Fake${currencyCode}`
+    }
+
     let display = `${currencyCode}`
 
     if (currencyCode === XRP && displaySymbol) {
diff --git a/src/containers/shared/components/test/Currency.test.tsx b/src/containers/shared/components/test/Currency.test.tsx
index 8d7de259c..b58c68c13 100644
--- a/src/containers/shared/components/test/Currency.test.tsx
+++ b/src/containers/shared/components/test/Currency.test.tsx
@@ -58,6 +58,13 @@ describe('Currency', () => {
     wrapper.unmount()
   })
 
+  it('handle non-standard currency decoded to equal or fewer than 3 characters', () => {
+    const wrapper = mount(
+      <Currency currency="5852500000000000000000000000000000000000" />,
+    )
+    expect(wrapper.find('.currency').text()).toEqual('FakeXRP')
+  })
+
   it('displays the XRP symbol when rendering XRP', () => {
     const wrapper = mount(<Currency currency="XRP" />)
     expect(wrapper.find('.currency').text()).toEqual('\uE900 XRP')