Skip to content

Publish to ECR #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rlukata merged 10 commits into from
Nov 21, 2024
Merged

Publish to ECR #54

rlukata merged 10 commits into from
Nov 21, 2024

Conversation

@rlukata
Copy link
Contributor

@rlukata rlukata commented Nov 21, 2024

No description provided.

morgangibbs87
morgangibbs87 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@morgangibbs87 morgangibbs87 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good:

  • Uses risc0/blobstream team in CODEOWNERS
  • Uses if statement to only run build-and-publish-image job for users/PRs originating from within org
  • Uses AWS EC2 runners (job picked up properly in Actions)

@rlukata rlukata marked this pull request as ready for review November 21, 2024 21:53
@rlukata rlukata requested a review from austinabell as a code owner November 21, 2024 21:53
@rlukata rlukata merged commit eaf8f2c into main Nov 21, 2024
3 checks passed
@rlukata rlukata deleted the austin/docker_pub branch November 21, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@austinabell austinabell austinabell approved these changes

@morgangibbs87 morgangibbs87 morgangibbs87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rlukata @austinabell @morgangibbs87