Skip to content

Commit 13c02f0

Browse files
committed
opcodes: blackfin: fix decoding of ABS
The single cycle dual mac ABS insn was incorrectly decoding the mac1 part of the insn. Once we fix the decode, update the gas tests to have the correct output. Signed-off-by: Mike Frysinger <[email protected]>
1 parent 4db6639 commit 13c02f0

File tree

5 files changed

+11
-3
lines changed

5 files changed

+11
-3
lines changed

gas/testsuite/ChangeLog

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
2011-02-13 Mike Frysinger <[email protected]>
2+
3+
* gas/bfin/arithmetic.d, gas/bfin/parallel.d: Change A0 to A1.
4+
15
2011-02-13 Mike Frysinger <[email protected]>
26

37
* gas/bfin/arithmetic.d, gas/bfin/parallel.d, gas/bfin/parallel3.d,

gas/testsuite/gas/bfin/arithmetic.d

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Disassembly of section .text:
1010
4: 10 c4 [0-3][[:xdigit:]] 40 A0 = ABS A1;
1111
8: 30 c4 [0-3][[:xdigit:]] 00 A1 = ABS A0;
1212
c: 30 c4 [0-3][[:xdigit:]] 40 A1 = ABS A1;
13-
10: 10 c4 [0-3][[:xdigit:]] c0 A1 = ABS A0, A0 = ABS A0;
13+
10: 10 c4 [0-3][[:xdigit:]] c0 A1 = ABS A1, A0 = ABS A0;
1414
14: 07 c4 10 80 R0 = ABS R2;
1515

1616
00000018 <add>:

gas/testsuite/gas/bfin/parallel.d

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Disassembly of section .text:
3737
74: fc b9 0a 9c
3838
78: 30 cc 00 40 A1 = ABS A1 \|\| FP = \[SP\] \|\| R3 = \[I2--\];
3939
7c: 77 91 93 9c
40-
80: 10 cc 00 c0 A1 = ABS A0, A0 = ABS A0 \|\| R4 = \[P5 \+ 0x38\] \|\| R0.H = W\[I0\];
40+
80: 10 cc 00 c0 A1 = ABS A1, A0 = ABS A0 \|\| R4 = \[P5 \+ 0x38\] \|\| R0.H = W\[I0\];
4141
84: ac a3 40 9d
4242
88: 07 cc 10 80 R0 = ABS R2 \|\| B\[SP\] = R0 \|\| R1.H = W\[I1\+\+\];
4343
8c: 30 9b 49 9c

opcodes/ChangeLog

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
2011-02-13 Mike Frysinger <[email protected]>
2+
3+
* bfin-dis.c (decode_dsp32alu_0): Fix typo with A1 reg.
4+
15
2011-02-13 Mike Frysinger <[email protected]>
26

37
* bfin-dis.c (decode_dsp32mult_0): Add 1 to dst for mac1. Output

opcodes/bfin-dis.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -3476,7 +3476,7 @@ decode_dsp32alu_0 (TIword iw0, TIword iw1, disassemble_info *outf)
34763476
OUTS (outf, " = (A0 += A1)");
34773477
}
34783478
else if (aop == 3 && HL == 0 && aopcde == 16)
3479-
OUTS (outf, "A1 = ABS A0, A0 = ABS A0");
3479+
OUTS (outf, "A1 = ABS A1, A0 = ABS A0");
34803480

34813481
else if (aop == 0 && aopcde == 23 && HL == 1)
34823482
{

0 commit comments

Comments
 (0)