Skip to content

Commit 4388303

Browse files
gnpricerishichirchi
authored andcommitted
notif [nfc]: Note a todo-i18n for display names of notif sound files
Toward zulip#277. These may be tricky to actually handle translating, particularly given the logic in _ensureInitNotificationSounds that looks at the filenames of existing files. They're also in a pretty obscure corner where I expect very few users see them, so not a priority. But they (a) are user-facing and (b) use English words ("chime", "low", "high") to communicate, so are squarely in the category of strings that should in principle get translated. Mark them as such.
1 parent 65aaf8c commit 4388303

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

lib/notifications/display.dart

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,11 @@ import '../widgets/theme.dart';
2525
AndroidNotificationHostApi get _androidHost => ZulipBinding.instance.androidNotificationHost;
2626

2727
enum NotificationSound {
28-
// Any new entry here must appear in `keep.xml` too, see #528.
28+
// TODO(i18n): translate these file display names
2929
chime2(resourceName: 'chime2', fileDisplayName: 'Zulip - Low Chime.m4a'),
3030
chime3(resourceName: 'chime3', fileDisplayName: 'Zulip - Chime.m4a'),
3131
chime4(resourceName: 'chime4', fileDisplayName: 'Zulip - High Chime.m4a');
32+
// Any new entry here must appear in `keep.xml` too, see #528.
3233

3334
const NotificationSound({
3435
required this.resourceName,

0 commit comments

Comments
 (0)