New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some code safety insights #135

Open

B1Z0N opened this issue Dec 23, 2022 · 1 comment

B1Z0N commented Dec 23, 2022 •

edited

Loading

Thanks for your contribution to opensource! There's some code safety improvements possible, for example:

scanf return value not taken into account. Possibly here(for example) and in other places.
Unfreed memory and unitialized memory access. Possibly here(for example) and in other places. Please check valgrind tool to mitigate this kind of safety flaws.
Excessive use of system calls without user input validation. Possibly here(for example) and in other places. Please see how it may be abused here.

The text was updated successfully, but these errors were encountered:

Owner

ritwik12 commented Dec 30, 2022

@B1Z0N Thanks for pointing those out. Feel free to open up a PR for the same. would be happy to have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment