Bug: Search and Replace dialogs become semitransparent when lose focus

[alex-ilin]

Notepad3 (64-bit) v5.19.108.1602

Actual: I don't like it, and I can't find a way to disable this behavior.

Just to give you an idea of where I was looking:

1. first of all, I looked through all the checkboxes on the dialog to make sure I didn't miss the new feature;
2. a few weeks later, when I got more annoyed by this new behavior, I looked completely through the main menu of the application, starting with the Settings, then went through View, then Edit, File and finally Help;
3. then I went to the official site to see if there was a newer version;
4. since my version was the newest, I searched through the announcement of its new features to see if the word "transparent" was mentioned, hoping I could see a way to disable the new feature in the announcement;
5. not finding anything, I went to the project's GitHub issues to see any mentions of "transparent" or "find" - maybe someone already complained about this and it's fixed in the development build, or maybe this feature was requested and there is an option to disable it mentioned in the discussion.

All of the above failed to yield any results. Actually, I don't even know who wanted or introduced this feature, as there seems to be no discussion or announcement made about it.

Expected: the find and replace dialogs should have a checkbox enabling transparency on deactivation.

In general it would be nice if the new features were announced in the release notes, defaulted to the old behavior (as opposed to bug fixes, which should default to the new behavior), and could be discovered and enabled/disabled by the user.

BTW, great job with this project! This is my new favorite editor for single text files, e.g. for git config core.editor. The crucial feature is to close it with Esc.

[RaiKoHoff]

You are right, so the new (see beta channel) version will have a switch:

[alex-ilin]

Super!

[RaiKoHoff]

Please test beta version _5.19.425.1673_develop (see beta-channel access #1129).

[alex-ilin]

In the beta version the checkbox works as expected, and the setting is correctly persisted. Should I keep this issue open until release, or when should I close it?

Also, when I'm running the beta, it shows an error on startup:

---------------------------
Notepad3
---------------------------
Error loading bitmap "Toolbar.bmp".
Need dimensions: 28 x 1 (width >= 28 x height).
---------------------------
OK   
---------------------------

The View - Toolbar - Toggle Toolbar works, and the toolbar becomes big (I've got a 4K screen) but the setting is not persisted, i.e. on the next start I see the same error message. If I keep the small toolbar size, the next run is not started with the error, i.e. only during startup there is a problem switching to the High DPI toolbar.

Another strange thing is that in the ini-file Settings section one of the lines is duplicated:

IndentWidth=0
IndentWidth=0

Should I create separate GitHub issues for these bugs, or is there a Beta channel feedback issue? How should I report these? Sometimes issues with betas are reported separately from the issues found in released versions.

[hpwamr]

Also, when I'm running the beta, it shows an error on startup:

---------------------------
Notepad3
---------------------------
Error loading bitmap "Toolbar.bmp".
Need dimensions: 28 x 1 (width >= 28 x height).
---------------------------
OK   
---------------------------

I'm running Notepad3 (64-bit) v5.19.425.1673 develop out-of-the-box and don't have this errors ? 🤔

But I confirm the duplicated lines in section: [settings] when "Indentation size = 0"

IndentWidth=0
IndentWidth=0

[alex-ilin]

The error message is only displayed by the 32-bit build (which I extracted by mistake). The 64-bit build silently ignores the High DPI setting and always starts with the small toolbar.

[hpwamr]

The 64-bit build silently ignores the High DPI setting and always starts with the small toolbar.

What does the "Toggle Toolbar" ?

[hpwamr]

5. not finding anything, I went to the project's GitHub issues to see any mentions of "transparent" or "find"

Hello @alexiljin, Just For Information:
At this point, the only place where this new feature has been mentioned is in: "Changes.txt" , line 60:

• 60 - Checkbox for transparent Find/Replace Dialogbox on loosing focus

PS: The fist part of the "Changes.txt" (from line 32 till +/- 128) corresponds to all the changes since the "Final Version 5.19.108.1602 (January 8, 2019)". 🤔

LEGEND:
--------------------------------------------------
1) NEW: (Added, Feature)
2) CHANGES:
3) ENHANCEMENT: (Optimize)
4) FIXES: (Debug)
5) REMOVED: 
6) TRANSLATIONS (MUI): (New Language)

[alex-ilin]

As I already said, the Toggle Toolbar switches to High DPI mode, but restarting the application reverts to the low DPI toolbar (due to this error).

PS: there is no such word as "loosing". It's either "losing" (which is correct in this context) or "loosening".

[hpwamr]

As I already said, the Toggle Toolbar switches to High DPI mode, but restarting the application reverts to the low DPI toolbar (due to this error).

Did you try with a "Pristine" Notepad3.ini : Notepad3.zip

[alex-ilin]

With the "Pristine" ini-file the issue is not reproduced: x64 build starts with a High DPI toolbar, and remembers the last setting on restart.

[alex-ilin]

Is it because you don't have an upgrade path from SettingsVersion=1 to SettingsVersion=2?

[alex-ilin]

I kind of want to preserve the settings I've accumulated in my old ini-file, and not reset everything to the "Pristine" state.

[RaiKoHoff]

@alexiljin : The HighDPIToolbar setting is maintained in the [Window] section of the .ini-file.
It depends also on the dimension of the screen, where Notepad3 has been closed/saved-settings.
If no settings are found, HighDPIToolbar is used, when screen dimensions are equal or exceed Full-HD (1920px X 1080px) automatically.
What are your "old" settings?

[alex-ilin]

@RaiKoHoff, I've downloaded the latest Notepad3Portable_5.19.527.1731_RC.paf.exe.7z, extracted the x64 exe-file and placed it in a folder with my existing Notepad3.ini, which was upgraded to SettingsVersion=2 on the first run of the new version (I've got save settings on exit enabled).
The zipped ini-file is attached:

For some reason GitHub failed to upload the zipped ini-file multiple times, so I had to give it the PNG extension. Please, rename back to ZIP, then extract.

If I start the new "Notepad3 (64-bit) v5.19.527.1731 RC" with this ini-file, I get the small Toolbar.
If I go to View - Toolbar - Toggle Toolbar, the toolbar correctly becomes big.
If I then save the settings (F7, or simply save on exit), I see in the ini-file that the setting is set to 1.

[Window]
3840x2160 HighDpiToolBar=1

However, on the next run I get the small toolbar again.

[RaiKoHoff]

@alexiljin : Better to open another issue for new stuff, since it is a complete differernt issue (see title of this issue).
But to answer your question here:
If you define in the configuration :

[Toolbar Images]
BitmapDefault=Toolbar.bmp
BitmapHot=ToolbarHot.bmp
BitmapDisabled=ToolbarDisabled.bmp

this will override any other toolbar settings 😸 .
Commenting out above settings should lead to expected behavior.

[hpwamr]

Hello @RaiKoHoff
Here his Notepad3_AlexIljin.zip (was a .png ext)

[RaiKoHoff]

Hello @hpwamr : already analyzed and answered. 😃

[alex-ilin]

@alexiljin : Better to open another issue for new stuff, since it is a complete differernt issue (see title of this issue).

Well, I've asked about it previously, but got no reply then. I've always thought that beta-release issues should be reported in a more lively channel (as there can be too many of them), while issue trackers such as this one should only contain things related to released versions, including feature requests - mostly from casual users, not beta testers.

I've created issue #1256 about the stuff that still bothers me about it.

[RaiKoHoff]

@alexiljin : Sorry for not answering your previous question.
Your thoughts about the beta-release channel and issue tracking are correct - the practice shows that this issue-tracker is also fine with the beta-releases, cause we have a version numbering of the betas, which can be correlated to pull-requests in the branches.
So, having not much beta tester, we are fine with that "bad practice" until we found a better solution 🤔

[alex-ilin]

The fix confirmed in Notepad3 (64-bit) v5.19.815.2595.
Thank you!