You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix 2280 by moving the bootstrap 3 classes out of SchemaField (#4579)
* Fix 2280 by moving the bootstrap 3 marker classes out of SchemaField
Fixed#2280 by moving marker classes from `SchemaField` to `WrapIfAdditionalTemplate`
- In `@rjsf/utils`, updated `WrapIfAdditionalTemplateProps` to pick up the `hideError` and `rawErrors` props from `FieldTemplateProps`
- In `@rjsf/core`, updated `SchemaField` to move the `form-group` and `field` marker classes to the `WrapIfAdditionalTemplate`
- Also moved the `field-error`, `has-error` and `has-danger` error marker classes
- Updated the grid snapshot due to the change
- Updated the snapshots in other themes due to the removed marker classes
- Updated the `CHANGELOG_v6.md` and `v6x upgrade guide.md` to reflect these changes
* - prefixed all rjsf marker classes with `rjsf-`
* - Added `field-hidden` to docs
* - Fixed build by redoing snapshots after running build
Copy file name to clipboardExpand all lines: CHANGELOG_v6.md
+13Lines changed: 13 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -25,6 +25,7 @@ should change the heading of the (upcoming) version to include a major version b
25
25
- BREAKING CHANGE: Removed support for version 4 of `antd`
26
26
- Updated `ArrayFieldItemTemplate` to replace `Button.Group` with `Space.Compact` since `Button.Group` is deprecated in `antd` version 5
27
27
- Upgraded to `@ant-design/icon@5`
28
+
- BREAKING CHANGE: Removed the addition of `Bootstrap 3` classes from the `SchemaField` and added `rjsf-` prefix to marker classes, thereby changing theme `FieldTemplate` className prop output and associated snapshots
28
29
29
30
## @rjsf/chakra-ui
30
31
@@ -33,6 +34,7 @@ should change the heading of the (upcoming) version to include a major version b
33
34
- BREAKING CHANGE: Refactored `ArrayFieldItemTemplate` to use the new `ArrayFieldItemButtonsTemplate`
34
35
- Updated the `ArrayFieldTemplate`, `ObjectFieldTemplate`, and `WrapIfAdditionalTemplate` to a unique id using the `buttonId()` function and adding consistent marker classes
35
36
- Implemented the `GridTemplate` component, adding it to the `templates` for the theme
37
+
- BREAKING CHANGE: Removed the addition of `Bootstrap 3` classes from the `SchemaField` and added `rjsf-` prefix to marker classes, thereby changing theme `FieldTemplate` className prop output and associated snapshots
36
38
37
39
## @rjsf/core
38
40
@@ -43,6 +45,9 @@ should change the heading of the (upcoming) version to include a major version b
43
45
- Implemented the `GridTemplate` component, adding it to the `templates` for the theme
44
46
- Implemented the new `LayoutGridField`, `LayoutMultiSchemaField` and `LayoutHeaderField` fields, adding them to the `fields` list
45
47
- BREAKING CHANGE: Removed support for the deprecated `schema.enumNames` and `uiSchema.classNames` as well as the deprecated `acceptcharset` prop on `Form`
48
+
- BREAKING CHANGE: Moved the addition of `Bootstrap 3` classes from the `SchemaField` to the `WrapIfAdditionalTemplate`, thereby affecting all the other themes, fixing [#2280](https://github.com/rjsf-team/react-jsonschema-form/issues/2280)
49
+
- BREAKING CHANGE: Added `rjsf-` prefix onto the following marker classes used in the fields and templates:
@@ -57,19 +62,26 @@ should change the heading of the (upcoming) version to include a major version b
57
62
- BREAKING CHANGE: Refactored `ArrayFieldItemTemplate` to use the new `ArrayFieldItemButtonsTemplate`
58
63
- Updated the `ArrayFieldTemplate`, `ObjectFieldTemplate`, and `WrapIfAdditionalTemplate` to a unique id using the `buttonId()` function and adding consistent marker classes
59
64
- Implemented the `GridTemplate` component, adding it to the `templates` for the theme
65
+
- BREAKING CHANGE: Removed the addition of `Bootstrap 3` classes from the `SchemaField` and added `rjsf-` prefix to marker classes, thereby changing theme `FieldTemplate` className prop output and associated snapshots
66
+
67
+
## @rjsf/material-ui
68
+
69
+
- BREAKING CHANGE: Deleted this theme in favor of `mui`
60
70
61
71
## @rjsf/mui
62
72
63
73
- BREAKING CHANGE: Refactored `ArrayFieldItemTemplate` to use the new `ArrayFieldItemButtonsTemplate`
64
74
- Updated the `ArrayFieldTemplate`, `ObjectFieldTemplate`, and `WrapIfAdditionalTemplate` to a unique id using the `buttonId()` function and adding consistent marker classes
65
75
- Updated the theme to use `Grid2` instead of the deprecated `Grid`
66
76
- Implemented the `GridTemplate` component, adding it to the `templates` for the theme
77
+
- BREAKING CHANGE: Removed the addition of `Bootstrap 3` classes from the `SchemaField` and added `rjsf-` prefix to marker classes, thereby changing theme `FieldTemplate` className prop output and associated snapshots
67
78
68
79
## @rjsf/semantic-ui
69
80
70
81
- BREAKING CHANGE: Refactored `ArrayFieldItemTemplate` to use the new `ArrayFieldItemButtonsTemplate`
71
82
- Updated the `ArrayFieldTemplate`, `ObjectFieldTemplate`, and `WrapIfAdditionalTemplate` to a unique id using the `buttonId()` function and adding consistent marker classes
72
83
- Implemented the `GridTemplate` component, adding it to the `templates` for the theme
84
+
- BREAKING CHANGE: Removed the addition of `Bootstrap 3` classes from the `SchemaField` and added `rjsf-` prefix to marker classes, thereby changing theme `FieldTemplate` className prop output and associated snapshots
73
85
74
86
## @rjsf/shadcn
75
87
@@ -98,6 +110,7 @@ should change the heading of the (upcoming) version to include a major version b
98
110
- BREAKING CHANGE: Removed the deprecated `getMatchingOption()` and `mergeValidationData()` from the library export and the `SchemaUtilsType` interface
99
111
- BREAKING CHANGE: Removed the deprecated `toErrorList()` function from the `ValidatorType` interface
100
112
- BREAKING CHANGE: Removed the deprecated `RJSF_ADDITONAL_PROPERTIES_FLAG` constant
113
+
- Updated the `WrapIfAdditionalTemplateProps` to include `hideError` and `rawErrors` in support of moving `Bootstrap 3` marker classes out of `SchemaField`
0 commit comments