Issue with nested if...then conditions

[anya92]

Prerequisites

• I have searched the existing issues
• I understand that providing a SSCCE example is tremendously useful to the maintainers.
• I have read the documentation
• Ideally, I'm providing a sample JSFiddle, Codesandbox.io or preferably a shared playground link demonstrating the issue.

What theme are you using?

core

Version

5.24.1

Current Behavior

There is a problem with nested if...then conditions inside properties. With liveOmit and omitExtraData enabled, the value of a property that is displayed conditionally is automatically removed.

Here is the JSON schema I am testing:

{
  "type": "object",
  "properties": {
    "object": {
      "title": "Object",
      "type": "object",
      "properties": {
        "name": {
          "title": "Name",
          "type": "string"
        },
        "booleanProperty": {
          "title": "Boolean Property",
          "default": true,
          "type": "boolean"
        }
      },
      "if": {
        "properties": {
          "booleanProperty": {
            "const": true
          }
        }
      },
      "then": {
        "properties": {
          "otherProperty": {
            "title": "Other Property",
            "type": "string",
            "enum": [
              "Hello",
              "World"
            ]
          }
        },
        "required": [
          "otherProperty"
        ]
      }
    }
  }
}

When the booleanProperty is set to true, the otherProperty field is displayed in the form, but its value cannot be changed because it is automatically cleared.

Expected Behavior

The value of otherProperty should not be cleared when booleanProperty is set to true.

Steps To Reproduce

1. Go to Playground.
2. Try to change Other Property value.

Environment

- OS:
- Node:
- npm:

Anything else?

No response

[heath-freenome]

Essentially a re-open of #4109. @anya92 do you feel comfortable updating the fix the @helen-m-lin provided? Or maybe they can continue improving the fix?

[anya92]

Thanks for the update. I think it would be best if @helen-m-lin continues with the fix, given their familiarity with the issue.

[helen-m-lin]

@anya92 @heath-freenome I can try to take a look next week. Thanks!

[anya92]

Hey @helen-m-lin, any updates on this? Thanks!

[helen-m-lin]

Hi @anya92, unfortunately I haven't had the chance to look into this issue. If this is urgent maybe someone else can take a look?

[shivsperfect]

HI @anya92 @helen-m-lin I looked into the issue, I have one clarification

from provided schema if we wrap if then inside the allOff it works just fine with live omit

example:
{
  "allOf": [
    {
      "if": {
        "properties": {
          "booleanProperty": {
            "const": true
          }
        }
      },
      "then": {
        "properties": {
          "otherProperty": {
            "title": "Other Property",
            "type": "string",
            "enum": [
              "Hello",
              "World"
            ]
          }
        },
        "required": [
          "otherProperty"
        ]
      }
    }
  ]
}

Are you guys expecting fix without changing the schema ? please let me know

Fyi @heath-freenome

[anya92]

Hi @shivsperfect!

Yes, I know that wrapping if-then inside allOf is a workaround, but I need a fix without changing the schema. The schema I provided (without anyOf) worked before, but it stopped working after a package release in the past. I already have existing schemas that my users created, so I can't update the rjsf package because it would break them in my application.

[shivsperfect]

sure @anya92 I will work on the fix, thanks for the context

[anya92]

Hi @shivsperfect, do you have any updates?