llvm 20

Author: drblallo

CMakeLists.txt

@@ -65,7 +65,7 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions")
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-rtti")
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror")
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra")
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-variable -Wno-unused-parameter -Wno-comment -Wno-unused-function -Wno-deprecated-this-capture")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-variable -Wno-unused-parameter -Wno-comment -Wno-unused-function -Wno-deprecated-this-capture -Wno-dangling-assignment-gsl")
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-implicit-int-float-conversion -Wno-reserved-macro-identifier -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-old-style-cast -Wno-sign-conversion -Wshadow-field-in-constructor -Wno-language-extension-token -Wno-deprecated-declarations -Wno-invalid-offsetof")
 
 set(CMAKE_INSTALL_RPATH "$ORIGIN/../lib")

build.py

@@ -231,7 +231,7 @@ def main():
             "--depth",
             "1",
             "-b",
-            "release/19.x",
+            "release/20.x",
         )
 
     if debug_llvm and not exists(llvm_install_debug_dir) and args.llvm_dir == "":

lib/backend/src/BackEnd.cpp

@@ -48,7 +48,6 @@ limitations under the License.
 #include "llvm/Support/raw_ostream.h"
 #include "llvm/Target/TargetMachine.h"
 #include "llvm/TargetParser/Host.h"
-#include "llvm/Transforms/Instrumentation.h"
 #include "llvm/Transforms/Instrumentation/SanitizerCoverage.h"
 #include "llvm/Transforms/Utils/Mem2Reg.h"
 #include "mlir/Conversion/FuncToLLVM/ConvertFuncToLLVMPass.h"
@@ -183,8 +182,8 @@ static void runOptimizer(
 	}
 	else
 	{
-		ModulePassManager MPM =
-				PB.buildO0DefaultPipeline(OptimizationLevel::O0, true);
+		ModulePassManager MPM = PB.buildO0DefaultPipeline(
+				OptimizationLevel::O0, ThinOrFullLTOPhase::None);
 		if (targetIsWindows)
 			MPM.addPass(createModuleToFunctionPassAdaptor(AddWindowsDLLExportPass()));
 		if (emitSanitizerInstrumentation and not targetIsWindows)
@@ -292,7 +291,7 @@ static void compile(
 	M->setDataLayout(*info.pimpl->datalayout);
 	llvm::UpgradeDebugInfo(*M);
 
-	auto &LLVMTM = static_cast<LLVMTargetMachine &>(*info.pimpl->targetMachine);
+	auto &LLVMTM = *info.pimpl->targetMachine;
 	auto *MMIWP = new MachineModuleInfoWrapperPass(&LLVMTM);
 
 	llvm::legacy::PassManager manager;
@@ -336,7 +335,7 @@ static mlir::LogicalResult getLinkerInvocation(
 	auto binDir = llvm::sys::path::parent_path(clangPath);
 	auto installDir = llvm::sys::path::parent_path(binDir);
 	llvm::SmallVector<char, 4> clangResourceDir;
-	llvm::sys::path::append(clangResourceDir, installDir, "lib", "clang", "19");
+	llvm::sys::path::append(clangResourceDir, installDir, "lib", "clang", "20");
 	driver.ResourceDir =
 			llvm::StringRef(clangResourceDir.data(), clangResourceDir.size());
 	if (targetMac and not llvm::sys::Process::GetEnv("SDKROOT"))

lib/dialect/include/rlc/dialect/ConstraintsAnalysis.hpp

@@ -153,10 +153,7 @@ namespace mlir::rlc
 		}
 
 		MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(ConstraintsLattice);
-		explicit ConstraintsLattice(mlir::ProgramPoint point)
-				: mlir::dataflow::AbstractDenseLattice(point)
-		{
-		}
+		using dataflow::AbstractDenseLattice::AbstractDenseLattice;
 
 		// Method for returning the lattice (useful only at the end) <- maybe can do
 		// everything in the class
@@ -227,7 +224,7 @@ namespace mlir::rlc
 				ConstraintsLattice>::DenseBackwardDataFlowAnalysis;
 
 		private:
-		void visitOperation(
+		mlir::LogicalResult visitOperation(
 				mlir::Operation* op,
 				const ConstraintsLattice& after,
 				ConstraintsLattice* before) override;

lib/dialect/include/rlc/dialect/ReachingDefinitions.hpp

@@ -30,10 +30,7 @@ namespace mlir
 		{
 			public:
 			MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(ReachingDefinitionsLattice);
-			explicit ReachingDefinitionsLattice(mlir::ProgramPoint point)
-					: mlir::dataflow::AbstractDenseLattice(point)
-			{
-			}
+			using dataflow::AbstractDenseLattice::AbstractDenseLattice;
 
 			mlir::ChangeResult meet(
 					const mlir::dataflow::AbstractDenseLattice& val) override
@@ -100,7 +97,7 @@ namespace mlir
 			using mlir::dataflow::DenseForwardDataFlowAnalysis<
 					ReachingDefinitionsLattice>::DenseForwardDataFlowAnalysis;
 
-			void visitOperation(
+			mlir::LogicalResult visitOperation(
 					mlir::Operation* op,
 					const ReachingDefinitionsLattice& before,
 					ReachingDefinitionsLattice* after) override
@@ -132,6 +129,7 @@ namespace mlir
 					propagateIfChanged(after, ChangeResult::Change);
 				else
 					propagateIfChanged(after, ChangeResult::NoChange);
+				return success();
 			}
 
 			void visitCallControlFlowTransfer(
@@ -147,7 +145,7 @@ namespace mlir
 				}
 				else
 				{
-					visitOperation(call, before, after);
+					auto _ = visitOperation(call, before, after);
 				}
 			}
 			void visitRegionBranchControlFlowTransfer(
@@ -159,16 +157,14 @@ namespace mlir
 			{
 				// when we are leaving the operation, we add our just defined operation
 				// to the list of things to destroy
-				visitOperation(branch, before, after);
+				auto _ = visitOperation(branch, before, after);
 			}
 
 			void setToEntryState(ReachingDefinitionsLattice* lattice) override {}
 
 			bool reachesOperation(mlir::Value value, mlir::Operation* op)
 			{
-				auto* lattice = op->getPrevNode() != nullptr
-														? getLattice(mlir::ProgramPoint(op->getPrevNode()))
-														: getLattice(op->getBlock());
+				auto* lattice = getLattice(LatticeAnchor(getProgramPointBefore(op)));
 				if (value.getType().isa<mlir::rlc::ContextType>() or
 						value.getType().isa<mlir::rlc::FrameType>())
 					return true;

lib/dialect/src/ActionLiveness.cpp

@@ -29,10 +29,7 @@ namespace mlir::rlc
 		{
 			public:
 			MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(ActionValueLivenessLattice);
-			explicit ActionValueLivenessLattice(mlir::ProgramPoint point)
-					: mlir::dataflow::AbstractDenseLattice(point)
-			{
-			}
+			using dataflow::AbstractDenseLattice::AbstractDenseLattice;
 
 			mlir::ChangeResult meet(
 					const mlir::dataflow::AbstractDenseLattice& val) override
@@ -101,6 +98,7 @@ namespace mlir::rlc
 			bool isAlive(mlir::Value val) { return content.contains(val); }
 
 			private:
+			mlir::ProgramPoint point;
 			llvm::DenseSet<mlir::Value> content;
 		};
 
@@ -154,14 +152,15 @@ namespace mlir::rlc
 				return toKill;
 			}
 
-			void visitOperation(
+			mlir::LogicalResult visitOperation(
 					mlir::Operation* op,
 					const ActionValueLivenessLattice& after,
 					ActionValueLivenessLattice* before) override
 			{
 				propagateIfChanged(
 						before,
 						before->joinAndMark(after, getJustUsed(op), getJustDefined(op)));
+				return mlir::success();
 			}
 
 			void visitCallControlFlowTransfer(
@@ -214,8 +213,8 @@ namespace mlir::rlc
 			public:
 			bool isDeadAfter(mlir::Value val, mlir::Operation* op)
 			{
-				auto* lattice = op != nullptr ? getLattice(mlir::ProgramPoint(op))
-																			: getLattice(op->getBlock());
+				assert(op != nullptr);
+				auto* lattice = getLattice(LatticeAnchor(getProgramPointAfter(op)));
 				return not lattice->isAlive(val);
 			}
 		};

lib/dialect/src/ConstraintsAnalysis.cpp

@@ -834,8 +834,9 @@ namespace mlir::rlc
 		}
 		else
 		{
-			this->ranges.insert(std::make_pair(
-					keyToInsert, createRange(min.value_or(MIN), max.value_or(MAX))));
+			this->ranges.insert(
+					std::make_pair(
+							keyToInsert, createRange(min.value_or(MIN), max.value_or(MAX))));
 			return true;
 		}
 	}
@@ -844,7 +845,7 @@ namespace mlir::rlc
 	// ConstraintsAnalysis METHODS
 	//////////////////////////////////////////////////////////////////////////////
 
-	void ConstraintsAnalysis::visitOperation(
+	mlir::LogicalResult ConstraintsAnalysis::visitOperation(
 			mlir::Operation* op,
 			const ConstraintsLattice& after,
 			ConstraintsLattice* before)
@@ -868,6 +869,7 @@ namespace mlir::rlc
 		{
 			propagateIfChanged(before, before->copy(after));
 		}
+		return mlir::success();
 	}
 
 	void ConstraintsAnalysis::visitCallControlFlowTransfer(
@@ -898,8 +900,9 @@ namespace mlir::rlc
 	// Useful debugging method
 	void ConstraintsAnalysis::printRanges(mlir::Operation* op)
 	{
-		auto* lattice = op != nullptr ? getLattice(mlir::ProgramPoint(op))
-																	: getLattice(op->getBlock());
+		assert(op != nullptr);
+		auto* lattice = getLattice(LatticeAnchor(getProgramPointBefore(op)));
+
 		lattice->print(llvm::outs());
 	}
 
@@ -909,14 +912,15 @@ namespace mlir::rlc
 			mlir::rlc::ConstraintsLattice::IntegerRange>&
 	ConstraintsAnalysis::getUnderlyingLattice(mlir::Operation* op)
 	{
-		return this->getLattice(mlir::ProgramPoint(op))->getUnderlyingLattice();
+		return getLattice(LatticeAnchor(getProgramPointBefore(op)))
+				->getUnderlyingLattice();
 	}
 
 	// Useful method
 	const mlir::rlc::ConstraintsLattice* ConstraintsAnalysis::getObjLattice(
 			mlir::Operation* op)
 	{
-		return this->getLattice(mlir::ProgramPoint(op));
+		return getLattice(LatticeAnchor(getProgramPointBefore(op)));
 	}
 
 	// Class which starts the analysis

lib/dialect/src/Conversion.cpp

@@ -225,8 +225,9 @@ class LowerMalloc: public mlir::OpConversionPattern<mlir::rlc::MallocOp>
 
 		const auto& dl = mlir::DataLayout::closest(op);
 
-		auto baseType = typeConverter->convertType(mlir::rlc::ProxyType::get(
-				op.getType().cast<mlir::rlc::OwningPtrType>().getUnderlying()));
+		auto baseType = typeConverter->convertType(
+				mlir::rlc::ProxyType::get(
+						op.getType().cast<mlir::rlc::OwningPtrType>().getUnderlying()));
 
 		auto baseSize = rewriter.getI64IntegerAttr(dl.getTypeSize(baseType));
 		auto count = rewriter.create<mlir::LLVM::ConstantOp>(
@@ -377,10 +378,13 @@ class ExplicitConstructRewriter
 				typeConverter->convertType(mlir::rlc::ProxyType::get(op.getType()));
 		auto alloca = makeAlloca(rewriter, mapped, op.getLoc());
 
-		rewriter.create<mlir::LLVM::CallOp>(
+		auto callOp = rewriter.create<mlir::LLVM::CallOp>(
 				op.getLoc(),
-				mlir::TypeRange(),
+				mlir::LLVM::LLVMFunctionType::get(
+						mlir::LLVM::LLVMVoidType::get(op.getContext()),
+						{ alloca.getType() }),
 				mlir::ValueRange({ adaptor.getInitializer(), alloca }));
+
 		rewriter.replaceOp(op, alloca);
 		return mlir::LogicalResult::success();
 	}
@@ -528,10 +532,11 @@ class IsOpRewriter: public mlir::OpConversionPattern<mlir::rlc::IsOp>
 			return mlir::success();
 		}
 
-		auto convertedUnionType = typeConverter
-																	->convertType(mlir::rlc::ProxyType::get(
-																			op.getExpression().getType()))
-																	.cast<mlir::LLVM::LLVMStructType>();
+		auto convertedUnionType =
+				typeConverter
+						->convertType(
+								mlir::rlc::ProxyType::get(op.getExpression().getType()))
+						.cast<mlir::LLVM::LLVMStructType>();
 		auto lastElementIndex = convertedUnionType.getBody().size() - 1;
 
 		auto zero = rewriter.getZeroAttr(rewriter.getI64Type());
@@ -629,8 +634,9 @@ class ValueUpcastRewriter
 		if (op.getInput().getType() != op.getResult().getType() and
 				not op.getInput().getType().isa<mlir::rlc::AlternativeType>())
 		{
-			op.emitError("internal error somehow a template upcast did not had the "
-									 "same input and output type at lowering time");
+			op.emitError(
+					"internal error somehow a template upcast did not had the "
+					"same input and output type at lowering time");
 			return mlir::failure();
 		}
 		rewriter.replaceOp(op, op.getInput());
@@ -1278,6 +1284,7 @@ class CallRewriter: public mlir::OpConversionPattern<mlir::rlc::CallOp>
 	{
 		rewriter.setInsertionPoint(op);
 		llvm::SmallVector<mlir::Value, 2> args;
+		llvm::SmallVector<mlir::Type, 2> argTypes;
 		assert(op.getNumResults() <= 1);
 		args.push_back(adaptor.getCallee());
 		auto loc = op.getLoc();
@@ -1296,10 +1303,16 @@ class CallRewriter: public mlir::OpConversionPattern<mlir::rlc::CallOp>
 		}
 
 		for (auto arg : adaptor.getArgs())
+		{
 			args.push_back(arg);
+			argTypes.push_back(arg.getType());
+		}
 
 		auto newOp = rewriter.create<mlir::LLVM::CallOp>(
-				op.getLoc(), mlir::ValueRange(), args);
+				op.getLoc(),
+				mlir::LLVM::LLVMFunctionType::get(
+						mlir::LLVM::LLVMVoidType::get(op.getContext()), argTypes),
+				args);
 
 		if (type.isa<mlir::rlc::ReferenceType>())
 			result = makeAlignedLoad(
@@ -1839,8 +1852,9 @@ class FunctionRewriter
 		{
 			auto subprogramAttr = diGenerator.getFunctionAttr(
 					newF, op.getUnmangledName(), op.getType());
-			newF->setLoc(mlir::FusedLoc::get(
-					op.getContext(), { newF.getLoc() }, subprogramAttr));
+			newF->setLoc(
+					mlir::FusedLoc::get(
+							op.getContext(), { newF.getLoc() }, subprogramAttr));
 
 			rewriter.setInsertionPointToStart(&newF.getBody().front());
 			for (auto [argument, value, newValue] : llvm::zip(