Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Belgium - RecycleApp - GetStreets returns alls streets containing "streetname" instead of equals #206

Open
pspiesschaert opened this issue Dec 5, 2024 · 2 comments

Comments

@pspiesschaert
Copy link

The RecycleApp implementation for Belgium only works when a city doesn't have multiple streets with a name containing the name entered in the settings. For example the request https://api.fostplus.be/recycle-public/app/v1/streets?q=Bosstraat&zipcodes=9820-44043 returns 3 streets: "Bosstraat", "Bergbosstraat" and "Kwenenbosstraat".
As a result, for a lot of cities in Belgium the RecycleApp implementation doesn't work.
Do you have more information on the available endpoints on the API or the ways the query can be changed to be equals instead of contains?

@robertraaijmakers
Copy link
Owner

robertraaijmakers commented Dec 13, 2024

Hm, is is quite a crappy API to implement. Because it is indeed based on all kind of in between selections. Currently the app has no way of determining this and it will also take quite a lot of time to implement this in a proper way. I will leave this ticket open, maybe there is some other dev out there in Belgium that has time to implement this in the app.

The full details of the API can be found here: https://github.com/robertraaijmakers/com.trashchecker/blob/main/trashapis.js#L544

There you can see that the current implementation is based on single responses, but as you stated, probably quite a few locations won't work due to double postal codes and streets.

@pspiesschaert
Copy link
Author

pspiesschaert commented Dec 13, 2024 via email

@robertraaijmakers robertraaijmakers added this to the 4.2.x milestone Jan 14, 2025
@robertraaijmakers robertraaijmakers removed this from the 5.0.x milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants