Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or remove attach_library twig reference #19

Open
antbrown opened this issue Apr 29, 2024 · 0 comments
Open

Fix or remove attach_library twig reference #19

antbrown opened this issue Apr 29, 2024 · 0 comments

Comments

@antbrown
Copy link

At the moment when viewing a FITS media entity I get the following warnings:

User warning: The following theme is missing from the file system: css in Drupal\Core\Extension\ExtensionPathResolver->getPathname() (line 63 of core/lib/Drupal/Core/Extension/ExtensionPathResolver.php).

Deprecated function: dirname(): Passing null to parameter #1 ($path) of type string is deprecated in Drupal\Core\Extension\ExtensionPathResolver->getPath() (line 85 of core/lib/Drupal/Core/Extension/ExtensionPathResolver.php).

I think this is being caused by an incorrect reference in the twig attach_library call, it should be module/library, so in this case islandora_fits/islandora_fits.

However, the library is already being attached correctly in https://github.com/roblib/islandora_fits/blob/8.x-1.x/src/Services/XMLTransform.php#L149, so the easiest solution might be to just remove the call to attach_library in the twig template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant