Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Load scenes rather than robot files for MJCF descriptions #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephane-caron opened this issue Apr 8, 2024 · 4 comments
Closed

Load scenes rather than robot files for MJCF descriptions #74

stephane-caron opened this issue Apr 8, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@stephane-caron
Copy link
Member

stephane-caron commented Apr 8, 2024

When loading a robot description from MuJoCo Menagerie, it seens it is more common to load the scene.xml files for each description rather than the individual robot files (that have, notably, no ground).

The proposal is then to make all MJCF descriptions loaded via robot_descriptions go for scene.xml by default, with optionally a variant #62 for bare robots.

@stephane-caron stephane-caron added the enhancement New feature or request label Apr 8, 2024
@stephane-caron
Copy link
Member Author

@kevinzakka Do you think this would make sense for the majority of users?

I can take care of making a PR for this, sometime in a not so-long time.

@lvjonok
Copy link
Contributor

lvjonok commented Apr 10, 2024

Let me add something from my experience of working with MJCF models. I, personally, didn't find many reasons behind holding very similar scene.xml from each Mujoco model and, thus, developed a tool, which automatically generated it given z position of floor intended.

I think a similar solution will be even better in long-term for general-purpose usage

@kevinzakka
Copy link
Contributor

In Menagerie, the scene.xml is mostly there to have consistent plane, lighting, free-camera settings and for overall aesthetics. I think it's more proper to load the canonical model and have a separate scene variant. In general, the variant option would be very useful :)

@stephane-caron
Copy link
Member Author

Thank you both for your feedback! Then it seems the best way forward is to allow it but not make it the default.

@robot-descriptions robot-descriptions locked and limited conversation to collaborators Apr 25, 2024
@stephane-caron stephane-caron converted this issue into discussion #79 Apr 25, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants