Skip to content

Commit 430e4ee

Browse files
committed
Remove libdc1394 1.x API
1 parent 15feafa commit 430e4ee

File tree

5 files changed

+9
-663
lines changed

5 files changed

+9
-663
lines changed

cmake/Findlibdc1394.cmake

Lines changed: 4 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -38,21 +38,7 @@ foreach(PATH $ENV{PATH})
3838
endforeach()
3939

4040
find_path(
41-
libdc1394_V1_INCLUDE_DIRS
42-
libdc1394/dc1394_control.h
43-
HINTS
44-
${libdc1394_INCLUDE_HINTS}
45-
PATHS
46-
$ENV{HOME}/include
47-
/usr/local/include
48-
/opt/local/include
49-
/usr/include
50-
)
51-
52-
mark_as_advanced(libdc1394_V1_INCLUDE_DIRS)
53-
54-
find_path(
55-
libdc1394_V2_INCLUDE_DIRS
41+
libdc1394_INCLUDE_DIRS
5642
dc1394/dc1394.h
5743
HINTS
5844
${libdc1394_INCLUDE_HINTS}
@@ -63,13 +49,7 @@ find_path(
6349
/usr/include
6450
)
6551

66-
mark_as_advanced(libdc1394_V2_INCLUDE_DIRS)
67-
68-
if(libdc1394_V1_INCLUDE_DIRS)
69-
set(libdc1394_INCLUDE_DIRS ${libdc1394_V1_INCLUDE_DIRS})
70-
elseif(libdc1394_V2_INCLUDE_DIRS)
71-
set(libdc1394_INCLUDE_DIRS ${libdc1394_V2_INCLUDE_DIRS})
72-
endif()
52+
mark_as_advanced(libdc1394_INCLUDE_DIRS)
7353

7454
foreach(PATH ${CMAKE_PREFIX_PATH})
7555
file(
@@ -107,19 +87,7 @@ foreach(PATH $ENV{PATH})
10787
endforeach()
10888

10989
find_library(
110-
libdc1394_V1_LIBRARY_RELEASE
111-
NAMES
112-
dc1394_control
113-
HINTS
114-
${libdc1394_LIBRARY_HINTS}
115-
PATHS
116-
$ENV{HOME}/lib
117-
/usr/local/lib
118-
/opt/local/lib
119-
/usr/lib
120-
)
121-
find_library(
122-
libdc1394_V2_LIBRARY_RELEASE
90+
libdc1394_LIBRARY_RELEASE
12391
NAMES
12492
dc1394
12593
HINTS
@@ -132,25 +100,10 @@ find_library(
132100
/usr/lib
133101
)
134102

135-
mark_as_advanced(libdc1394_V1_LIBRARY_RELEASE)
136-
mark_as_advanced(libdc1394_V2_LIBRARY_RELEASE)
137-
138-
if(libdc1394_V1_LIBRARY_RELEASE)
139-
set(libdc1394_LIBRARY_RELEASE ${libdc1394_V1_LIBRARY_RELEASE})
140-
elseif(libdc1394_V2_LIBRARY_RELEASE)
141-
set(libdc1394_LIBRARY_RELEASE ${libdc1394_V2_LIBRARY_RELEASE})
142-
endif()
103+
mark_as_advanced(libdc1394_LIBRARY_RELEASE)
143104

144105
select_library_configurations(libdc1394)
145106

146-
if(libdc1394_V1_LIBRARY_RELEASE AND libdc1394_V1_INCLUDE_DIRS)
147-
set(libdc1394_DEFINITIONS -DLIBDC1394_VERSION_MAJOR=10)
148-
elseif(libdc1394_V2_LIBRARY_RELEASE AND libdc1394_V2_INCLUDE_DIRS)
149-
set(libdc1394_DEFINITIONS -DLIBDC1394_VERSION_MAJOR=20)
150-
endif()
151-
152-
mark_as_advanced(libdc1394_DEFINITIONS)
153-
154107
find_package_handle_standard_args(
155108
libdc1394
156109
FOUND_VAR libdc1394_FOUND

demos/rlCameraDemo/rlCameraDemo.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ main(int argc, char** argv)
3535
{
3636
try
3737
{
38-
rl::hal::Dc1394Camera dc1394(argc > 1 ? argv[1] : "");
38+
rl::hal::Dc1394Camera dc1394(argc > 1 ? std::stoi(argv[1]) : 0);
3939

4040
dc1394.open();
4141
dc1394.start();

src/rl/hal/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,6 @@ if(RL_BUILD_HAL_COMEDI)
216216
endif()
217217

218218
if(RL_BUILD_HAL_LIBDC1394)
219-
target_compile_definitions(hal PUBLIC ${libdc1394_DEFINITIONS})
220219
target_include_directories(hal PUBLIC ${libdc1394_INCLUDE_DIRS})
221220
target_link_libraries(hal ${libdc1394_LIBRARIES})
222221
endif()

0 commit comments

Comments
 (0)