Add error handling and improve tests with fixures

Author: rocktimsaikia

github_dlr/source.py

@@ -70,6 +70,7 @@ def download_content(download_url, output_file):
     """Download a single downloadable file given a download URL."""
 
     resp = requests.get(download_url)
+    resp.raise_for_status()
     resp_content = resp.content
 
     with open(output_file, mode="wb") as file:

tests/download_test.py

@@ -1,27 +1,37 @@
 import os
-import shutil
+
+import pytest
+import requests
 
 from github_dlr.source import download_content
 
 
-def test_download_content_succes(requests_mock):
+def test_download_content_succes(requests_mock, tmp_path):
     download_url = "https://github.com/AnimeChan/animechan/tree/main/client/public"
     mock_content = b"This is an image content"
 
     requests_mock.get(download_url, content=mock_content)
 
-    # Create a temp dir `tmp` to store the test files
-    output_dir = "tmp"
-    output_file = os.path.join(output_dir, "foo.txt")
-    os.makedirs(output_dir)
+    # Use tmp_path fixure to create temp file path
+    output_file = os.path.join(tmp_path, "foo.txt")
+    print(output_file)
 
     # Download the file content and save it locally
     download_content(download_url, output_file)
 
-    try:
-        # Verify the file was written correctly
-        with open(output_file, "rb") as file:
-            assert file.read() == mock_content
-    finally:
-        if os.path.exists(output_file):
-            shutil.rmtree(output_dir)
+    # Verify the file was written correctly
+    with open(output_file, "rb") as file:
+        assert file.read() == mock_content
+
+
+def test_download_content_failure(requests_mock, tmp_path):
+    download_url = "https://github.com/AnimeChan/animechan/tree/main/client/public"
+
+    requests_mock.get(download_url, status_code=404)
+
+    # Create a temp dir `tmp` to store the test files
+    output_file = os.path.join(tmp_path, "foo.txt")
+    print(output_file)
+
+    with pytest.raises(requests.exceptions.RequestException):
+        download_content(download_url, output_file)