File tree 2 files changed +12
-3
lines changed
2 files changed +12
-3
lines changed Original file line number Diff line number Diff line change @@ -28,7 +28,9 @@ don't have test cases for.
28
28
could lead to bugs and issues in the test code.
29
29
- Use [ type hints] ( https://docs.python.org/3/library/typing.html ) in your code to improve code readability
30
30
and to detect possible bugs earlier.
31
- - Avoid wildcard imports
31
+ - Avoid wildcard imports.
32
+ - If more than one name from a module is needed, use lexicographically sorted multi-line imports
33
+ in order to reduce the possibility of potential merge conflicts.
32
34
- Use a module-level docstring to describe what the test is testing, and how it
33
35
is testing it.
34
36
- When subclassing the BitcoinTestFramework, place overrides for the
Original file line number Diff line number Diff line change 14
14
from collections import defaultdict
15
15
16
16
# Avoid wildcard * imports
17
- from test_framework .blocktools import (create_block , create_coinbase )
18
- from test_framework .messages import CInv , MSG_BLOCK
17
+ # Use lexicographically sorted multi-line imports
18
+ from test_framework .blocktools import (
19
+ create_block ,
20
+ create_coinbase ,
21
+ )
22
+ from test_framework .messages import (
23
+ CInv ,
24
+ MSG_BLOCK ,
25
+ )
19
26
from test_framework .p2p import (
20
27
P2PInterface ,
21
28
msg_block ,
You can’t perform that action at this time.
0 commit comments