Skip to content

Commit 78957e7

Browse files
author
MacroFake
committed
Merge bitcoin#25486: test: fix failing test interface_usdt_utxocache.py
f665c6e test: fix failing test interface_usdt_utxocache.py (Sebastian Falbesoner) Pull request description: The `from_node` argument doesn't exist anymore for `MiniWallet.create_self_transfer` since PR bitcoin#25435 (commit fa8421b), leading to an error on master: ``` $ sudo ./test/functional/interface_usdt_utxocache.py 2022-06-27T17:45:35.585000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_7s1djjo1 2022-06-27T17:45:36.515000Z TestFramework (INFO): testing the utxocache:uncache tracepoint API 2022-06-27T17:45:36.517000Z TestFramework (ERROR): Unexpected exception caught during testing Traceback (most recent call last): File "/home/honeybadger/bitcoin/test/functional/test_framework/test_framework.py", line 133, in main self.run_test() File "/home/honeybadger/bitcoin/./test/functional/interface_usdt_utxocache.py", line 149, in run_test self.test_uncache() File "/home/honeybadger/bitcoin/./test/functional/interface_usdt_utxocache.py", line 172, in test_uncache invalid_tx = self.wallet.create_self_transfer( TypeError: create_self_transfer() got an unexpected keyword argument 'from_node' 2022-06-27T17:45:36.568000Z TestFramework (INFO): Stopping nodes [...] ``` Fix this by removing the argument. (Unfortunately, the USDT tests don't seem to run on any CI target, I guess that's due to missing permissions to hook into the kernel.) ACKs for top commit: MarcoFalke: cr ACK f665c6e Tree-SHA512: 74f8e398739a25ab5518ff71b998d03d4e529a786ba5b424509de81a511ad3e2e1cd38a5b7bb9f1f5a21340391d6807f4951ff39fa3a2ad65a3b11b989eebea6
2 parents ee3ba5a + f665c6e commit 78957e7

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

test/functional/interface_usdt_utxocache.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,7 @@ def test_uncache(self):
169169

170170
# Create a transaction and invalidate it by changing the txid of the previous
171171
# output to the coinbase txid of the block at height 1.
172-
invalid_tx = self.wallet.create_self_transfer(
173-
from_node=self.nodes[0])["tx"]
172+
invalid_tx = self.wallet.create_self_transfer()["tx"]
174173
invalid_tx.vin[0].prevout.hash = int(block_1_coinbase_txid, 16)
175174

176175
self.log.info("hooking into the utxocache:uncache tracepoint")

0 commit comments

Comments
 (0)