Try using g++ rather clang++ for linux build (#56)

* Try using g++ rather clang++ for linux build

* Update V8 static library for macos-latest (#55)

Co-authored-by: rogchap <[email protected]>

* Update V8 static library for ubuntu-latest (#57)

Co-authored-by: rogchap <[email protected]>

* avoid clang warnings for macos build

* Update V8 static library for macos-latest (#58)

Co-authored-by: rogchap <[email protected]>

* Update the changelog

* remove repository dispatch trigger for v8 build

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: rogchap <[email protected]>

Author: rogchap

.github/workflows/v8build.yml

@@ -1,6 +1,6 @@
 name: V8 Build
 
-on: [workflow_dispatch,repository_dispatch]
+on: workflow_dispatch
 
 jobs:
     build:
@@ -15,7 +15,11 @@ jobs:
               with:
                   submodules: true
                   fetch-depth: 1
-            - name: Build V8
+            - name: Build V8 linux
+              if: matrix.platform == 'ubuntu-latest'
+              run: cd deps && ./build.py --no-clang
+            - name: Build V8 macOS
+              if: matrix.platform == 'macos-latest'
               run: cd deps && ./build.py
             - name: Create PR
               uses: peter-evans/create-pull-request@v3

CHANGELOG.md

@@ -10,6 +10,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Value methods for checking value kind (is string, number, array etc)
 - C formatting via `clang-format` to aid future development
 
+### Changed
+- Use g++ (default for cgo) for linux builds of the static v8 lib
+
 ## [v0.3.0]
 
 ### Added

deps/build.py

@@ -7,7 +7,8 @@
 
 parser = argparse.ArgumentParser()
 parser.add_argument('--debug', dest='debug', action='store_true')
-parser.set_defaults(debug=False)
+parser.add_argument('--no-clang', dest='clang', action='store_false')
+parser.set_defaults(debug=False, clang=True)
 args = parser.parse_args()
 
 deps_path = os.path.dirname(os.path.realpath(__file__))
@@ -43,8 +44,8 @@
 
 gn_args = """
 is_debug=%s
+is_clang=%s
 clang_use_chrome_plugins=false
-linux_use_bundled_binutils=false
 use_custom_libcxx=false
 use_sysroot=false
 symbol_level=0
@@ -57,9 +58,7 @@
 v8_enable_gdbjit=false
 v8_enable_i18n_support=false
 v8_enable_test_features=false
-v8_extra_library_files=[]
 v8_untrusted_code_mitigations=false
-v8_use_snapshot=true
 """
 
 def v8deps():
@@ -85,7 +84,8 @@ def main():
     env = os.environ.copy()
 
     is_debug = 'true' if args.debug else 'false'
-    gnargs = gn_args % is_debug
+    is_clang = 'true' if args.clang else 'false'
+    gnargs = gn_args % (is_debug, is_clang)
     gen_args = gnargs.replace('\n', ' ')
 
     subprocess.check_call([gn_path, "gen", build_path, "--args=" + gen_args],