Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Poktroll Feedback] Umbrella ticket for feedback from the Pocket Network Protocol team at GROVE #282

Closed
4 tasks done
jcstein opened this issue Dec 13, 2023 · 1 comment · Fixed by #290
Closed
4 tasks done

Comments

@jcstein
Copy link
Member

jcstein commented Dec 13, 2023

From @Olshansk:

Going to share some feedback/suggestions for potentially improving the docs (before I forget). I'd make the PR myself but just not enough time to commit to sit down and do a good job on it.

  • "The Polaris EVM rollup contains some details that anyone needs to deploy a rollup but it is not something I read through or had the inkling of needing to read through. The full and sequencer node rollup setup section under Advanced is a good start but it'd be helpful to have a instructions to deploy your sequencer to mocha testnet section as well (covering some of the questions we had above)." (NOTE: this is completed in feat: update gm tutorial parts 2 testnet and 3 mainnet #290)
    • (a) noted feedback on Polaris guide. the details are useful for others, so they will be left in for now. (b) re: instructions to deploy your sequencer to mocha testnet, sounds like a good idea. to pull this guide from within the existing tutorial
  • "How to select a namespace isn't very clear, so I suggest having a helper similar to: NAMESPACE_ID=$(echo -n $NAMESPACE_NAME | openssl dgst -sha256 -binary | head -c 8 | xxd -p)"
    • what does this helper do differently?
  • "Add a link to the testnet faucet [1] with a copy-paste $request <addr> command to make it easier for the devs."(NOTE: this is celestia-specific, and done on the testnet pages linked to already. running and funding node should be referenced in celestia docs. also since the testnet faucet for mocha is in discord, I think we should leave it this way for now. unless user is in the discord already, it won't take them to the channel)
  • "In order to verify that things are working, suggesting an explorer (e.g. celenium.io) where you can enter your namespace and validate it's running was a great source of truth to validate our assumptions."
    • good idea. mocha.celenium.io for mocha and [TBD] for arabica
@jcstein jcstein changed the title feedback for documentation from Pokt [Poktroll Feedback] Umbrella ticket for feedback from the Pocket Network Protocol team at GROVE Dec 14, 2023
@Olshansk
Copy link
Contributor

Olshansk commented Dec 14, 2023

Improve documentation related to consensus configurations:

Rollkit leverages the Cosmos SDK, which leverages CometBFT (formely known as Tendermint). However, Tendermint/CometBFT configurations are overriden, which can lead to some confusion.

Adding an Admonition that explicitly says (please paraphrase) the following could save devs a lot of time:

Look here:

Don't look here:

jcstein added a commit that referenced this issue Jan 9, 2024
and context to what they are in docs
resolves remainder of #282

Co-Authored-By: Daniel Olshansky <[email protected]>
jcstein added a commit that referenced this issue Jan 10, 2024
* feat: begin updating for testnet version

* feat: script edits for mingasprice

* fix: remove ns and auth token

* feat: add both LNs to top section

* feat: use v0.12.1-rc4 for celestia-da

* feat: use v0.12.3

* feat: update testnet tutorial

* feat: update mainnet testnet tuts

* fix: 1 to one etc.

* feat: update mainnet/testnet

* feat: add construction signs

* feat: add gmworld namespace

* feat: add helper for namespaces

and context to what they are in docs
resolves remainder of #282

Co-Authored-By: Daniel Olshansky <[email protected]>

---------

Co-authored-by: Daniel Olshansky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants