Skip to content

Commit 24ed2cc

Browse files
gaearonromaindso
authored andcommitted
Skip React frames that are too close (facebook#2143)
1 parent 85bf8fd commit 24ed2cc

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

packages/react-error-overlay/src/utils/warnings.js

+15
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,26 @@ function massage(
1313

1414
// Reassemble the stack with full filenames provided by React
1515
let stack = '';
16+
let lastFilename;
17+
let lastLineNumber;
1618
for (let index = 0; index < frames.length; ++index) {
1719
const { fileName, lineNumber } = frames[index];
1820
if (fileName == null || lineNumber == null) {
1921
continue;
2022
}
23+
24+
// TODO: instead, collapse them in the UI
25+
if (
26+
fileName === lastFilename &&
27+
typeof lineNumber === 'number' &&
28+
typeof lastLineNumber === 'number' &&
29+
Math.abs(lineNumber - lastLineNumber) < 3
30+
) {
31+
continue;
32+
}
33+
lastFilename = fileName;
34+
lastLineNumber = lineNumber;
35+
2136
let { functionName } = frames[index];
2237
functionName = functionName || '(anonymous function)';
2338
stack += `in ${functionName} (at ${fileName}:${lineNumber})\n`;

0 commit comments

Comments
 (0)