Skip to content

Commit 6697836

Browse files
Justkantromaindso
authored andcommitted
Webpack config typo (facebook#2193)
* Webpack config typo * Webpack config more typo
1 parent 48133d8 commit 6697836

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/react-scripts/config/webpack.config.dev.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -146,10 +146,10 @@ module.exports = {
146146
include: paths.appSrc,
147147
},
148148
// ** ADDING/UPDATING LOADERS **
149-
// The "url" loader handles all assets unless explicitly excluded.
149+
// The "file" loader handles all assets unless explicitly excluded.
150150
// The `exclude` list *must* be updated with every change to loader extensions.
151151
// When adding a new loader, you must add its `test`
152-
// as a new entry in the `exclude` list for "url" loader.
152+
// as a new entry in the `exclude` list for "file" loader.
153153

154154
// "file" loader makes sure those assets get served by WebpackDevServer.
155155
// When you `import` an asset, you get its (virtual) filename.
@@ -233,7 +233,7 @@ module.exports = {
233233
],
234234
},
235235
// ** STOP ** Are you adding a new loader?
236-
// Remember to add the new extension(s) to the "url" loader exclusion list.
236+
// Remember to add the new extension(s) to the "file" loader exclusion list.
237237
],
238238
},
239239
plugins: [

packages/react-scripts/config/webpack.config.prod.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,10 @@ module.exports = {
145145
include: paths.appSrc,
146146
},
147147
// ** ADDING/UPDATING LOADERS **
148-
// The "url" loader handles all assets unless explicitly excluded.
148+
// The "file" loader handles all assets unless explicitly excluded.
149149
// The `exclude` list *must* be updated with every change to loader extensions.
150150
// When adding a new loader, you must add its `test`
151-
// as a new entry in the `exclude` list in the "url" loader.
151+
// as a new entry in the `exclude` list in the "file" loader.
152152

153153
// "file" loader makes sure those assets end up in the `build` folder.
154154
// When you `import` an asset, you get its filename.
@@ -243,7 +243,7 @@ module.exports = {
243243
// Note: this won't work without `new ExtractTextPlugin()` in `plugins`.
244244
},
245245
// ** STOP ** Are you adding a new loader?
246-
// Remember to add the new extension(s) to the "url" loader exclusion list.
246+
// Remember to add the new extension(s) to the "file" loader exclusion list.
247247
],
248248
},
249249
plugins: [

0 commit comments

Comments
 (0)