Remove static markup from NodeStreamRenderer

daviddt · web-flow · commit 4f533620dac5 · 2018-08-01T09:05:09.000+02:00
The API docs did not match the actual behaviour. 
htmlStart &amp; htmlEnd should be variables that can be passed to the function, currently they are static defined in the function.
diff --git a/src/server/ReactDOMNodeStreamRenderer.js b/src/server/ReactDOMNodeStreamRenderer.js
@@ -99,12 +99,7 @@ function originalRenderToNodeStream(element, cache, streamingStart, memLife=0) {
   return new ReactMarkupReadableStream(element, false, cache, streamingStart, memLife);
 }
 
-export function renderToNodeStream(element, cache, res) {
-
-  const htmlStart =
-  '<html><head><title>Page</title></head><body><div id="react-root">';
-
-  const htmlEnd = '</div></body></html>';
+export function renderToNodeStream(element, cache, res, htmlStart, htmlEnd) {
 
   const streamingStart = {
     sliceStartCount: htmlStart.length, 
@@ -131,11 +126,7 @@ function originalRenderToStaticNodeStream(element, cache, streamingStart, memLif
   return new ReactMarkupReadableStream(element, true, cache, streamingStart, memLife);
 }
 
-export function renderToStaticNodeStream(element, cache, res) {
-  const htmlStart =
-  '<html><head><title>Page</title></head><body><div id="react-root">';
-
-  const htmlEnd = '</div></body></html>';
+export function renderToStaticNodeStream(element, cache, res, htmlStart, htmlEnd) {
 
   const streamingStart = {
     sliceStartCount: htmlStart.length, 
