Skip to content

Commit 05f7420

Browse files
committed
Do not allow spaces in package name
1 parent 3d55650 commit 05f7420

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

app/responders/ropensci/approve_responder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ class ApproveResponder < Responder
77

88
def define_listening
99
@event_action = "issue_comment.created"
10-
@event_regex = /\A@#{bot_name} approve( [ \.\w-]*[ \w-]+)?\.?\s*\z/i
10+
@event_regex = /\A@#{bot_name} approve( [\.\w-]*[\w-]+)?\.?\s*\z/i
1111
end
1212

1313
def process_message(message)

spec/responders/ropensci/approve_responder_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
it "should define regex" do
2121
expect(@responder.event_regex).to match("@ropensci-review-bot approve")
2222
expect(@responder.event_regex).to match("@ropensci-review-bot approve package-name")
23+
expect(@responder.event_regex).to match("@ropensci-review-bot approve package.name")
2324
expect(@responder.event_regex).to match("@ropensci-review-bot approve package-name \r\n")
2425
expect(@responder.event_regex).to_not match("@ropensci-review-bot approve package-name. another-command")
2526
expect(@responder.event_regex).to_not match("@ropensci-review-bot approve package-name\r\nanother-command")

0 commit comments

Comments
 (0)