Skip to content

Commit 0e66bc5

Browse files
committed
Get external service names in WelcomeResponder
1 parent e8c63b2 commit 0e66bc5

2 files changed

Lines changed: 14 additions & 4 deletions

File tree

app/responders/welcome_responder.rb

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,18 @@ def process_message(message)
4848
def external_service(service_params)
4949
return if service_params.nil? || service_params.empty?
5050

51-
services = service_params.is_a?(Array) ? service_params : [service_params]
52-
services.each do |service_config|
51+
external_services = []
52+
if service_params.is_a?(Array)
53+
service_params.each do |single_service|
54+
single_service.each_pair do |service_name, service_config|
55+
external_services << service_config.merge({ name: service_name.to_s})
56+
end
57+
end
58+
else
59+
external_services << service_params
60+
end
61+
62+
external_services.each do |service_config|
5363
check_required_params(service_config)
5464
process_external_service(service_config, locals)
5565
end

spec/responders/welcome_responder_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,8 +241,8 @@
241241
before do
242242
settings = { env: {bot_github_user: "botsci"} }
243243
services = [
244-
{ name: "service1", url: "http://example1.com", data_from_issue: ["extra-data"] },
245-
{ name: "service2", url: "http://example2.com" }
244+
{ service1: { url: "http://example1.com", data_from_issue: ["extra-data"] }},
245+
{ service2: { url: "http://example2.com" }}
246246
]
247247
@responder = subject.new(settings, {external_service: services})
248248
@responder.context = OpenStruct.new(issue_id: 33,

0 commit comments

Comments
 (0)