Fix #1345

Author: wlandau

DESCRIPTION

@@ -12,7 +12,7 @@ Description: Pipeline tools coordinate the pieces of computationally
   The methodology in this package
   borrows from GNU 'Make' (2015, ISBN:978-9881443519)
   and 'drake' (2018, <doi:10.21105/joss.00550>).
-Version: 1.8.0.9002
+Version: 1.8.0.9003
 License: MIT + file LICENSE
 URL: https://docs.ropensci.org/targets/, https://github.com/ropensci/targets
 BugReports: https://github.com/ropensci/targets/issues

NEWS.md

@@ -1,8 +1,9 @@
-# targets 1.8.0.9002 (development)
+# targets 1.8.0.9003 (development)
 
 * Un-break workflows that use `format = "file_fast"` (#1339, @koefoeden).
 * Fix deadlock in `error = "trim"` (#1340, @koefoeden).
 * Remove tailored debugging message (#1341, @koefoeden).
+* Store warnings while writing to storage (#1345, @Aariq).
 
 # targets 1.8.0
 

R/class_builder.R

@@ -189,7 +189,6 @@ target_conclude.tar_builder <- function(target, pipeline, scheduler, meta) {
   on.exit(builder_unset_tar_runtime())
   builder_set_tar_runtime(target, NULL)
   target_update_queue(target, scheduler)
-  builder_handle_warnings(target, scheduler)
   builder_ensure_workspace(
     target = target,
     pipeline = pipeline,
@@ -198,6 +197,7 @@ target_conclude.tar_builder <- function(target, pipeline, scheduler, meta) {
   )
   builder_ensure_object(target, "main")
   builder_ensure_correct_hash(target)
+  builder_handle_warnings(target, scheduler)
   switch(
     metrics_outcome(target$metrics),
     cancel = builder_cancel(target, pipeline, scheduler, meta),
@@ -453,7 +453,19 @@ builder_update_object <- function(target) {
   on.exit(builder_unload_value(target))
   file_validate_path(target$store$file$path)
   if (!identical(target$settings$storage, "none")) {
-    store_write_object(target$store, target$value$object)
+    withCallingHandlers(
+      store_write_object(target$store, target$value$object),
+      warning = function(condition) {
+        if (length(target$metrics$warnings) < 51L) {
+          target$metrics$warnings <- paste(
+            c(target$metrics$warnings, build_message(condition)),
+            collapse = ". "
+          )
+        }
+        warning(as_immediate_condition(condition))
+        invokeRestart("muffleWarning")
+      }
+    )
   }
   store_hash_late(target$store)
   store_upload_object(target$store)

tests/testthat/test-class_builder.R

@@ -706,3 +706,34 @@ tar_test("error = \"trim\" on a dynamic branch", {
   progress <- tar_progress(names = tidyselect::any_of(names))
   expect_equal(unique(progress$progress), "skipped")
 })
+
+tar_test("capture storage warnings", {
+  skip_cran()
+  tar_script(
+    list(
+      tar_target(
+        x, {
+          warning("run_warning")
+          123L
+        },
+        format = tar_format(
+          read = function(path) {
+            readRDS(path)
+          },
+          write = function(object, path) {
+            warning("storage_warning")
+            saveRDS(object, path)
+          }
+        )
+      )
+    )
+  )
+  suppressWarnings(
+    expect_warning(
+      tar_make(callr_function = NULL),
+      class = "tar_condition_run"
+    )
+  )
+  expect_equal(tar_read(x), 123L)
+  expect_equal(tar_meta(x)$warnings, "run_warning. storage_warning")
+})