(nice-to-have) move filtering classes to common pkgs

[dirk-thomas]

From @130s on February 7, 2013 2:26

I know it wasn't intended when rqt_console was initially written to make all those filter classes to be generic. But it would be very beneficial to have a set of filtering components that provide multiple types of filters and users can select / de-select them on GUI while system aggregates the result from all selected filters (like rqt_console does).

Copied from original issue: ros-visualization/rqt_common_plugins#30

[dirk-thomas]

From @130s on February 7, 2013 2:28

I'm writing filtering function (for this enhancement) and noticed that one tiny detail that prohibits generalization is MessageFilter hardcodes the type of regex as exact-match (actual code is here). I'd rather use indexIn. It'd be nice to be able to select matching type.

[dirk-thomas]

Could you elaborate a bit more what the issue currently is and how that should to be improved? Based on the issue title, the two comments and the referenced other issue I can not comprehend what this issue is about.

[dirk-thomas]

From @130s on February 8, 2013 1:58

This is an enhancement, not an issue.

I found that the filtering feature that rqt_console has is generic and useful (although it might have not been intended to be used from other pkgs). I'm suggesting to make its API generic.

Nevermind the issue I referenced in the 1st comment.

[dirk-thomas]

From @ablasdel on September 2, 2013 13:35

I think the filter funtionality is very specific in console.

What other plugin would you consider adding such an elaborate filter to?

Unless we can define what would need it I think it would be best to close this as wont fix.

[dirk-thomas]

From @130s on September 3, 2013 4:32

I don't have time to look at carefully but I thought I made rqt_reconfigure depend on console, or at least copy-paste its code to realize filtering.

(Isn't making general API good idea in general btw? )

[dirk-thomas]

From @ablasdel on September 3, 2013 4:40

Yes it is I just didn't see anywhere someone would want to use it. If you used it in rqt reconfigure I'm all for moving it out at some point for reduced code duplication. But as you said low priority.