Skip to content

Commit a62623e

Browse files
authored
Fix ternary null check found by clang static analysis (#176)
Signed-off-by: Stephen Brawner <[email protected]>
1 parent 4d1f4f0 commit a62623e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/class_loader_core.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ void addClassLoaderOwnerForAllExistingMetaObjectsForLibrary(
343343
reinterpret_cast<void *>(meta_obj), meta_obj->baseClassName().c_str(),
344344
meta_obj->className().c_str(),
345345
reinterpret_cast<void *>(loader),
346-
nullptr == loader ? loader->getLibraryPath().c_str() : "NULL");
346+
nullptr == loader ? "NULL" : loader->getLibraryPath().c_str());
347347
meta_obj->addOwningClassLoader(loader);
348348
}
349349
}
@@ -362,7 +362,7 @@ void revivePreviouslyCreateMetaobjectsFromGraveyard(
362362
"bound to ClassLoader %p (library path = %s)",
363363
obj->className().c_str(), obj->baseClassName().c_str(), reinterpret_cast<void *>(obj),
364364
reinterpret_cast<void *>(loader),
365-
nullptr == loader ? loader->getLibraryPath().c_str() : "NULL");
365+
nullptr == loader ? "NULL" : loader->getLibraryPath().c_str());
366366

367367
obj->addOwningClassLoader(loader);
368368
assert(obj->typeidBaseClassName() != "UNSET");
@@ -391,7 +391,7 @@ void purgeGraveyardOfMetaobjects(
391391
".bound to ClassLoader %p (library path = %s)",
392392
obj->className().c_str(), obj->baseClassName().c_str(), reinterpret_cast<void *>(obj),
393393
reinterpret_cast<void *>(loader),
394-
nullptr == loader ? loader->getLibraryPath().c_str() : "NULL");
394+
nullptr == loader ? "NULL" : loader->getLibraryPath().c_str());
395395

396396
bool is_address_in_graveyard_same_as_global_factory_map =
397397
std::find(all_meta_objs.begin(), all_meta_objs.end(), *itr) != all_meta_objs.end();

0 commit comments

Comments
 (0)