Skip to content

Commit c3b159f

Browse files
fix: use the default destructor that automatically drops the zenoh reply/query and hence sends the final signal (#473) (#475)
(cherry picked from commit 4fc36b7) Co-authored-by: Yuyuan Yuan <[email protected]>
1 parent f071960 commit c3b159f

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

rmw_zenoh_cpp/src/detail/zenoh_utils.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,6 @@ std::chrono::nanoseconds::rep ZenohQuery::get_received_timestamp() const
5353
return received_timestamp_;
5454
}
5555

56-
///=============================================================================
57-
ZenohQuery::~ZenohQuery() {}
58-
5956
///=============================================================================
6057
const zenoh::Query & ZenohQuery::get_query() const {return query_;}
6158

@@ -68,9 +65,6 @@ ZenohReply::ZenohReply(
6865
received_timestamp_ = received_timestamp;
6966
}
7067

71-
///=============================================================================
72-
ZenohReply::~ZenohReply() {}
73-
7468
///=============================================================================
7569
const zenoh::Reply & ZenohReply::get_sample() const
7670
{

rmw_zenoh_cpp/src/detail/zenoh_utils.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class ZenohReply final
4040
public:
4141
ZenohReply(const zenoh::Reply & reply, std::chrono::nanoseconds::rep received_timestamp);
4242

43-
~ZenohReply();
43+
~ZenohReply() = default;
4444

4545
const zenoh::Reply & get_sample() const;
4646

@@ -58,7 +58,7 @@ class ZenohQuery final
5858
public:
5959
ZenohQuery(const zenoh::Query & query, std::chrono::nanoseconds::rep received_timestamp);
6060

61-
~ZenohQuery();
61+
~ZenohQuery() = default;
6262

6363
const zenoh::Query & get_query() const;
6464

0 commit comments

Comments
 (0)