Skip to content

Commit 98c2be3

Browse files
author
Chris Park
committed
Merge branch 'develop'
2 parents 0e25536 + c3e3e97 commit 98c2be3

File tree

6 files changed

+32
-52
lines changed

6 files changed

+32
-52
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ api.rosette(endpoint, function(err, res){
5353
| targetScheme | name translation | No |
5454
| options | relationships | No |
5555
| accuracyMode | relationships | Yes |
56-
| linked (deprecated) | entities | No |
5756
| linkEntities | entities | No |
5857
| explain | sentiment | No |
5958
| morphology | morphology | Yes |

examples/entities_linked.js

Lines changed: 0 additions & 28 deletions
This file was deleted.

lib/entities.js

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,7 @@ function entities() {
3939
entities.prototype.getResults = function(parameters, userKey, protocol, serviceURL, callback) {
4040

4141
if (parameters.documentFile != null) {
42-
if (parameters.loadParams().linked == true) {
43-
console.warn("entities/linked endpoint has been combined with /entities. Do not specify the linked parameter.");
44-
parameters.loadFile(parameters.loadParams().documentFile, parameters, userKey, protocol, serviceURL, "entities/linked", callback);
45-
} else {
4642
parameters.loadFile(parameters.loadParams().documentFile, parameters, userKey, protocol, serviceURL, "entities", callback);
47-
}
48-
49-
50-
5143
} else {
5244

5345
// validate parameters
@@ -57,13 +49,7 @@ entities.prototype.getResults = function(parameters, userKey, protocol, serviceU
5749
return callback(new RosetteException("badArgument", "Cannot supply both Content and ContentUri", "bad arguments"));
5850
} else {
5951
// configure URL
60-
if (parameters.loadParams().linked == true) {
61-
console.warn("entities/linked endpoint is deprecated and has been combined with entities. No need to specify linked parameter.");
62-
var urlParts = URL.parse(serviceURL + "entities/linked");
63-
} else {
64-
urlParts = URL.parse(serviceURL + "entities");
65-
}
66-
52+
var urlParts = URL.parse(serviceURL + "entities");
6753

6854
var req = new rosetteRequest();
6955
req.makeRequest('POST', userKey, protocol, urlParts, parameters, callback);

lib/parameters.js

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ var http = require("http");
2323
var https = require("https");
2424
var zlib = require("zlib");
2525

26+
var querystring = require('querystring');
27+
2628
/**
2729
* Compatible server version.
2830
*
@@ -63,9 +65,6 @@ function parameters() {
6365
this.options = null;
6466
this.accuracyMode = null;
6567

66-
//entities parameters
67-
this.linked = null;
68-
6968
//sentiment parameters
7069
this.explain = null;
7170
this.shortString = null;
@@ -76,6 +75,9 @@ function parameters() {
7675
//headers
7776
this.customHeaders = null;
7877

78+
//URL parameters
79+
this.urlParameters = null;
80+
7981
}
8082

8183
/**
@@ -102,7 +104,8 @@ parameters.prototype.loadParams = function() {
102104
"options": this.options,
103105
"explain": this.explain,
104106
"short-string": this.shortString,
105-
"_customHeaders": this.customHeaders
107+
"_customHeaders": this.customHeaders,
108+
"_urlParameters": this.urlParameters
106109
};
107110

108111
for (var key in paramJSON) {
@@ -155,11 +158,23 @@ parameters.prototype.loadFile = function(filePath, loadedParameters, userKey, pr
155158
}
156159
headers["X-RosetteAPI-Key"] = userKey;
157160

161+
if (parameters.customHeaders != null) {
162+
parameters.customHeaders.forEach(function(element, index) {
163+
headers[element[0]] = element[1];
164+
});
165+
}
166+
167+
var path = urlParts.path;
168+
169+
if (parameters.urlParameters != null) {
170+
path = path + '?' + querystring.stringify(parameters.urlParameters);
171+
}
172+
158173
var result = new Buffer("");
159174

160175
var options = {
161176
hostname: urlParts.hostname,
162-
path: urlParts.path,
177+
path: path,
163178
method: 'POST',
164179
headers: headers,
165180
agent: false

lib/rosetteRequest.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,14 @@ var zlib = require("zlib");
2121
var rosetteConstants = require("./rosetteConstants");
2222
var RosetteException = require("./rosetteExceptions");
2323

24+
var querystring = require('querystring');
25+
2426
/**
2527
* Compatible server version.
2628
*
2729
* @type string
2830
*/
29-
var BINDING_VERSION = "1.4.0";
31+
var BINDING_VERSION = "1.5.0";
3032

3133
/**
3234
* @class
@@ -69,9 +71,15 @@ rosetteRequest.prototype.makeRequest = function(requestType, userKey, protocol,
6971

7072
}
7173

74+
var path = urlParts.path;
75+
76+
if (parameters.urlParameters != null) {
77+
path = path + '?' + querystring.stringify(parameters.urlParameters);
78+
}
79+
7280
var options = {
7381
hostname: urlParts.hostname,
74-
path: urlParts.path,
82+
path: path,
7583
method: requestType,
7684
headers: headers,
7785
agent: false

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "rosette-api",
3-
"version": "1.4.0",
3+
"version": "1.5.0",
44
"description": "Rosette API Node.js client SDK",
55
"main": "index",
66
"directories": {

0 commit comments

Comments
 (0)