Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell - fsop, incorrect restarting of progress window timeout after error #424

Open
rozniak opened this issue Jan 31, 2025 · 0 comments
Open
Assignees
Labels
bug Something isn't working good first issue Good for newcomers lib-shell Issue relates to the shell library.

Comments

@rozniak
Copy link
Owner

rozniak commented Jan 31, 2025

Noticed an oversight with the logic for pausing/restarting the timeout for the copy/move progress dialog. If there's no window displayed yet, the timeout should be paused until the error is cleared. ATM it restarts the timer without checking if it was paused:

https://github.com/rozniak/xfce-winxp-tc/blob/master/shared/shell/src/fsop.c#L649

Need to track whether the timer was just paused. Checking if the timeout id is 0 won't do the job because it will be 0 once the progress window has spawned.

@rozniak rozniak added bug Something isn't working good first issue Good for newcomers lib-shell Issue relates to the shell library. labels Jan 31, 2025
@rozniak rozniak self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers lib-shell Issue relates to the shell library.
Projects
None yet
Development

No branches or pull requests

1 participant