Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taskband - Start button and username displayed in start menu use the wrong font with Japanese locale #432

Open
unexp opened this issue Feb 21, 2025 · 14 comments
Assignees
Labels
bug Something isn't working missing-styles Theme is missing styles or controls appear broken program-taskband Issue relates to the taskband program.

Comments

@unexp
Copy link
Contributor

unexp commented Feb 21, 2025

From a bit of tweaking with fonts I think the correct font for the start button is MS UI Gothic (which I don't think is bundled with the project yet), not sure about the username

Expected behavior (Windows XP SP3)

Image

Current behavior with xfce-winxp-tc:

Image

@unexp unexp changed the title taskband - Start button and username displayed in start menu use the wrong font taskband - Start button and username displayed in start menu use the wrong font with Japanese locale Feb 21, 2025
@unexp
Copy link
Contributor Author

unexp commented Feb 21, 2025

System font in general seems to be MS UI Gothic 9pt (I think so at least) on Windows XP SP3 with the Japanese locale, you should probably add that if possible

@rozniak
Copy link
Owner

rozniak commented Feb 21, 2025

MS UI Gothic instead of Tahoma? 🤔

@unexp
Copy link
Contributor Author

unexp commented Feb 21, 2025

MS UI Gothic instead of Tahoma? 🤔

It seems like it, I've looked for a bit and MS UI Gothic looks about right

@rozniak rozniak self-assigned this Feb 21, 2025
@unexp
Copy link
Contributor Author

unexp commented Feb 21, 2025

MS UI Gothic instead of Tahoma? 🤔

It seems like it, I've looked for a bit and MS UI Gothic looks about right

Image

Image

The ellipsis look different but all the other letters seem to be the same

@rozniak
Copy link
Owner

rozniak commented Feb 21, 2025

Do you want to try changing Franklin Gothic Medium to MS UI Gothic here and recompile the Luna (Blue) theme to see whether it looks correct?

https://github.com/rozniak/xfce-winxp-tc/blob/master/themes/luna/blue/gtk-3.0/styling/start-menu.scss#L105

@unexp
Copy link
Contributor Author

unexp commented Feb 21, 2025

Sure, give me a moment

@unexp
Copy link
Contributor Author

unexp commented Feb 21, 2025

Do you want to try changing Franklin Gothic Medium to MS UI Gothic here and recompile the Luna (Blue) theme to see whether it looks correct?

https://github.com/rozniak/xfce-winxp-tc/blob/master/themes/luna/blue/gtk-3.0/styling/start-menu.scss#L105

It looks about right it just needs to be bold, I just don't know how to make it both bold and italic because I don't work with GTK or sass

Image

@rozniak
Copy link
Owner

rozniak commented Feb 21, 2025

If you change the last parameter from undefined to bold it should make it bold - it should already be italic (can see it is in that screenshot... very slightly).

@unexp
Copy link
Contributor Author

unexp commented Feb 21, 2025

Looks pretty close now but the original looks bolder

Image

@rozniak
Copy link
Owner

rozniak commented Feb 21, 2025

That does look far better - it might be the best that can be done in GTK3 (at least with what I know atm, unless something can be fudged with Pango).

Kind of awkward to get a change like this to work across locales since the theme doesn't change... perhaps a CSS class can be added to the Start menu if running under a locale that should have special handling. 🤔

@unexp
Copy link
Contributor Author

unexp commented Feb 21, 2025

Either that or I'm looking at the wrong font, I'm not sure

@rozniak rozniak added bug Something isn't working missing-styles Theme is missing styles or controls appear broken program-taskband Issue relates to the taskband program. labels Feb 21, 2025
@rozniak
Copy link
Owner

rozniak commented Feb 21, 2025

I'll have a play around with it some more - probably need to check over other non-Latin locales as well. Appreciate your patience with the testing. 😁

@unexp
Copy link
Contributor Author

unexp commented Feb 21, 2025

No problem :)

@unexp
Copy link
Contributor Author

unexp commented Feb 21, 2025

Username font seems to also be MS UI Gothic Bold

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working missing-styles Theme is missing styles or controls appear broken program-taskband Issue relates to the taskband program.
Projects
None yet
Development

No branches or pull requests

2 participants