Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Complete!" message of dnf upgrade overlaps with the old log #1899

Closed
junjieyuan opened this issue Nov 25, 2024 · 6 comments
Closed

The "Complete!" message of dnf upgrade overlaps with the old log #1899

junjieyuan opened this issue Nov 25, 2024 · 6 comments
Assignees
@kontura
Labels
Priority: HIGH Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take

Comments

@junjieyuan
Copy link

Please see the second to last line:

vlcsnap-2024-11-26-01h01m45s986

"dnf upgrade" video:

VID_20241126012256.mp4

OS: Fedora Server 41

dnf --version

dnf5 version 5.2.7.0
dnf5 plugin API version 2.0
libdnf5 version 5.2.7.0
libdnf5 plugin API version 2.0

Loaded dnf5 plugins:
name: automatic
version: 1.0.0
API version: 2.0

name: builddep
version: 1.0.0
API version: 2.0

name: changelog
version: 1.0.0
API version: 2.0

name: config-manager
version: 0.1.0
API version: 2.0

name: copr
version: 0.1.0
API version: 2.0

name: needs_restarting
version: 1.0.0
API version: 2.0

name: repoclosure
version: 1.0.0
API version: 2.0
@rnayabed
Copy link

Bump: https://discussion.fedoraproject.org/t/dnf5-misses-a-newline-before-printing-the-final-transaction-result/138365

@kontura kontura added Priority: HIGH Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take labels Nov 26, 2024
@kontura
Copy link
Contributor

kontura commented Nov 26, 2024 •
edited
Loading

Thanks for the report, I am setting a high priority because a lot of people see this.
I think it is likely caused by #1805.

@kontura kontura self-assigned this Nov 26, 2024
@avinal
Copy link

avinal commented Nov 27, 2024

I saw the Complete!ng and thought this was a spelling mistake. There is also an incomplete arch or noarch probably due to the same issue.

Complete!ng trigger-install scriptlet: glibc-common-0:2.40-12.fc41.x86_6464c41.x86_64hrch

@sunwire sunwire mentioned this issue Nov 28, 2024
Closed
@geraldosimiao geraldosimiao mentioned this issue Dec 3, 2024
Closed
@geraldosimiao
Copy link

It seem's the fix didn't get to the new f42 build https://bodhi.fedoraproject.org/updates/FEDORA-2024-de59b25ef6
Screenshot_20241204_005436

@ppisar
Copy link
Contributor

ppisar commented Dec 4, 2024

Of course not because there is no fix yet.

kontura added a commit to kontura/dnf5 that referenced this issue Dec 4, 2024
@kontura
Fix overwriting of old output from MultiProgressBar
8077a29 
Since PR rpm-software-management#1825
we are overwriting old output instead of specifically clearing it.
This causes problems when messages are removed from progressbars like it
happens when scriptlets finish successfully without any logs.

Closes: rpm-software-management#1899

Also adds couple describing comments.
@evan-goode evan-goode mentioned this issue Dec 4, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2024
@kontura @m-blaha
Fix overwriting of old output from MultiProgressBar
ef6b744 
Since PR #1825
we are overwriting old output instead of specifically clearing it.
This causes problems when messages are removed from progressbars like it
happens when scriptlets finish successfully without any logs.

Closes: #1899

Also adds couple describing comments.
@kontura
Copy link
Contributor

kontura commented Dec 5, 2024

This should be fixed by: #1925

@kontura kontura closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kontura kontura

Labels
Priority: HIGH Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ppisar @kontura @rnayabed @junjieyuan @geraldosimiao @avinal