Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document explicit nevra remove commands and aliases dropped #1120

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
7c73828
Document explicit nevra remove commands and aliases dropped
ashuk2000 Jan 2, 2024
00c2680
doc: Introduce caching man page
jan-kolarik Dec 18, 2023
beb9630
doc: Update the main page regarding cache
jan-kolarik Dec 18, 2023
05aeae5
doc: Document changes related to caching
jan-kolarik Dec 18, 2023
3649b62
dnf5daemon-server: Add RPM package Group attribute
Conan-Kudo Jan 3, 2024
b5564f5
Add dnf5.conf man page
inknos Jul 20, 2023
09ecf65
Disable zchunk on RHEL
yselkowitz Jan 5, 2024
4c47334
Packaging: Require an exact release of libdnf5-cli by dnf5-plugins
ppisar Jan 5, 2024
5ad1a40
Limit search pattern for remove command to NEVRAs and files
j-mracek Jan 4, 2024
611380b
Update of documentation for remove command behavior
j-mracek Jan 4, 2024
870a8a0
[Minor] Update of documentation of repoquery
j-mracek Jan 4, 2024
0793b76
repoquery: when filtering by --file we need to load filelists
kontura Sep 19, 2023
c6361e8
repoquery: remove unused include
kontura Sep 19, 2023
063c1c8
repoquery: add `--providers-of=PACKAGE_ATTRIBUTE` option
kontura Sep 19, 2023
6fa8618
repoquery: add `--recursive` option
kontura Sep 19, 2023
7d27fef
D-Bus: Fix download_end signal name in org.rpm.dnf.v0.Base interface
ppisar Jan 8, 2024
b84f2f9
Workaround for swig-4.2.0 missing fragment dependency
wsfulton Jan 8, 2024
58e0f11
Make cachedir, system_cachedir relative to installroot
evan-goode Jan 8, 2024
e762070
Remove unused headers in goal_elements.hpp
kontura Jan 3, 2024
d681cbf
Fix `--skip-unavailable` documentation
kontura Jan 9, 2024
22be22b
Update translations from weblate
invalid-email-address Jan 11, 2024
9111440
Release 5.1.11
inknos Jan 11, 2024
5a8f2df
I18N: Do not mark empty strings for a translation
ppisar Jan 12, 2024
b2eb54a
I18N: Remove duplicate empty message IDs from catalogs
ppisar Jan 12, 2024
cac334e
Fix misspellings
rffontenelle Jan 15, 2024
57fe937
group: Fix using allowerasing option
jan-kolarik Jan 15, 2024
aeddd1e
Define tp_str slot for Reldep Class
j-mracek Dec 12, 2023
609d66e
Add __repr__() to python bindings of Reldep
j-mracek Dec 13, 2023
c5239c9
Add __hash__() for Reldep Python binding
j-mracek Dec 13, 2023
c1a1d4c
Add __hash__(), __str__(), and __repr__() for Package
j-mracek Dec 13, 2023
2fc4c2c
Use placeholders to deduplicate strings
rffontenelle Jan 12, 2024
c74e990
Fix code for string deduplication
rffontenelle Jan 15, 2024
692245f
Fix clang format
rffontenelle Jan 15, 2024
50277b6
package_query: Fix filter_version with non EQ comparator
m-blaha Jan 4, 2024
d745092
Extend filter_release and filter_version tests
m-blaha Jan 4, 2024
24a67a4
Document explicit nevra remove commands and aliases dropped
ashuk2000 Jan 2, 2024
47648b4
Merge branch 'fix-issue-758-759' of github.com:ashuk2000/dnf5 into fi…
Jan 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,23 @@
# 5.1.11

- Update translations from weblate
- Fix `--skip-unavailable` documentation
- Make `cachedir`, `system_cachedir` relative to `installroot`
- Workaround for swig-4.2.0 missing fragment dependency
- Add `repoquery --recursive` option
- Add `repoquery --providers-of=PACKAGE_ATTRIBUTE` option
- Update documentation of repoquery
- Update documentation for remove command behavior
- Limit search pattern for remove command to NEVRAs and files
- Packaging: Require an exact release of libdnf5-cli by dnf5-plugins
- Disable zchunk on RHEL
- Add dnf5.conf man page
- Add RPM package Group attribute to dnf5daemon-server
- Document changes related to caching
- Document caching man page
- Document Global Option `--help-cmd` dropped
- log_event: Correct message for HINT_ICASE

# 5.1.10

- Document dnf5 plugins
Expand Down Expand Up @@ -69,7 +89,7 @@
- modules: Simplify finding whether profile is default in module list
- modules: Fix `ModuleProfile::is_default` method
- modules: Store if profile is default in ModuleProfile object
- Generate docs for undocummented functions so they at least show up
- Generate docs for undocumented functions so they at least show up
- Add python advisory docs
- Add advisory python API tests
- Enable AdvisoryModule bindings
Expand Down Expand Up @@ -156,7 +176,7 @@
- Abort PGP checking immediately if any checks fail
- Display warning message when any PGP checks skipped
- Don't allow main gpgcheck=0 to override repo config
- gups and environments to `history info` ouput
- gups and environments to `history info` output
- Store missing id and repoid in db for groups/environments
- Fix out-of-bounds access in Goal::Impl::add_install_to_goal
- Fix repoquery `--list`
Expand Down
2 changes: 1 addition & 1 deletion VERSION.cmake
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
set(DEFAULT_PROJECT_VERSION_MAJOR 5)
set(DEFAULT_PROJECT_VERSION_MINOR 1)
set(DEFAULT_PROJECT_VERSION_PATCH 10)
set(DEFAULT_PROJECT_VERSION_PATCH 11)

if(DEFINED PROJECT_VERSION_MAJOR)
if(NOT ${DEFAULT_PROJECT_VERSION_MAJOR} STREQUAL ${PROJECT_VERSION_MAJOR})
Expand Down
29 changes: 29 additions & 0 deletions bindings/libdnf5/common.i
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,35 @@ del ClassName##__iter__
#endif
%enddef

%define add_str(ClassName)
#if defined(SWIGPYTHON)
%extend ClassName {
std::string __str__() const {
return $self->to_string();
}
}
#endif
%enddef

%define add_repr(ClassName)
#if defined(SWIGPYTHON)
%extend ClassName {
std::string __repr__() const {
return $self->to_string_description();
}
}
#endif
%enddef

%define add_hash(ClassName)
#if defined(SWIGPYTHON)
%extend ClassName {
int __hash__() const {
return $self->get_hash();
}
}
#endif
%enddef

%{
#include "libdnf5/common/sack/query.hpp"
Expand Down
5 changes: 5 additions & 0 deletions bindings/libdnf5/repo.i
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@
%import "common.i"
%import "conf.i"

#if SWIG_VERSION == 0x040200
// https://github.com/swig/swig/issues/2744
%fragment("SwigPyIterator_T");
#endif

%exception {
try {
$action
Expand Down
8 changes: 8 additions & 0 deletions bindings/libdnf5/rpm.i
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
}
}


%{
#include "libdnf5/rpm/arch.hpp"
#include "libdnf5/rpm/checksum.hpp"
Expand Down Expand Up @@ -61,12 +62,19 @@
%include "libdnf5/rpm/package_sack.hpp"
%template(PackageSackWeakPtr) libdnf5::WeakPtr<libdnf5::rpm::PackageSack, false>;

add_str(libdnf5::rpm::Reldep)
add_repr(libdnf5::rpm::Reldep)
add_hash(libdnf5::rpm::Reldep)
%include "libdnf5/rpm/reldep.hpp"

%rename(next) libdnf5::rpm::ReldepListIterator::operator++();
%rename(value) libdnf5::rpm::ReldepListIterator::operator*();
%include "libdnf5/rpm/reldep_list_iterator.hpp"
%include "libdnf5/rpm/reldep_list.hpp"

add_str(libdnf5::rpm::Package)
add_repr(libdnf5::rpm::Package)
add_hash(libdnf5::rpm::Package)
%include "libdnf5/rpm/package.hpp"

%template(VectorPackage) std::vector<libdnf5::rpm::Package>;
Expand Down
2 changes: 1 addition & 1 deletion bindings/perl5/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ elseif(PERL_INSTALLDIRS STREQUAL "vendor")
elseif(PERL_INSTALLDIRS STREQUAL "site")
set(PERL_INSTALL_PATH "${PERL_SITEARCH}")
else()
message(FATAL_ERROR "Uknown PERL_INSTALLDIRS value: ${PERL_INSTALLDIRS}")
message(FATAL_ERROR "Unknown PERL_INSTALLDIRS value: ${PERL_INSTALLDIRS}")
endif()
message(STATUS "Perl5 files will be installed to ${PERL_INSTALL_PATH}")

Expand Down
10 changes: 5 additions & 5 deletions bindings/python3/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ function(add_python3_module LIBRARY_NAME MODULE_NAME)
set(SWIG_COMPILE_OPTIONS ${SWIG_COMPILE_OPTIONS}
-Wno-redundant-decls
)
# Currenly the SWIG_PYTHON_SILENT_MEMLEAK controls only whether message:
# Currently the SWIG_PYTHON_SILENT_MEMLEAK controls only whether message:
# "swig/python detected a memory leak of type '%s', no destructor found." is printed, used here:
# https://github.com/swig/swig/blob/33f6a2d0b2c3d90b928f56ddfa599afe87903f76/Lib/python/pyrun.swg#L776
# We want to supress this message due to a bug in Python part of swig.
# We want to suppress this message due to a bug in Python part of swig.
# The core of the issue is that Python Swig has a global list of types used in all swig modules. This is
# needed because the modules are interlinked eg. libdnf5::Base is used in all of them. During finalization
# of the Python runtime unused modules are cleaned up before garbage collector runs and cleans global objects.
# This can result in a situation where for example libdnf5.advisory module is destoyed, removing its types
# from the global swig types list includeing libdnf5.base.Base, and only after that a global libdnf5.base.Base
# is garbage collected which is now missing type information -> no destructor can be called -> swig want's to
# This can result in a situation where for example libdnf5.advisory module is destroyed, removing its types
# from the global swig types list including libdnf5.base.Base, and only after that a global libdnf5.base.Base
# is garbage collected which is now missing type information -> no destructor can be called -> swig wants to
# print the message
# There is an issue reported on SWIG with the same root cause: https://github.com/swig/swig/issues/2037 it
# also contains more details.
Expand Down
2 changes: 1 addition & 1 deletion common/utils/regex.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ along with libdnf. If not, see <https://www.gnu.org/licenses/>.
#define LIBDNF5_UTILS_REGEX_HPP


// Limit the string legth, because GCC std::regex_match() exhausts a stack on very long strings.
// Limit the string length, because GCC std::regex_match() exhausts a stack on very long strings.
#define MAX_STRING_LENGTH_FOR_REGEX_MATCH 2 << 10


Expand Down
2 changes: 1 addition & 1 deletion dnf5-plugins/builddep_plugin/builddep.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ void BuildDepCommand::run() {
auto goal = get_context().get_goal();
goal->set_allow_erasing(allow_erasing->get_value());

// Search only for solution in provides and files. Use buildrequire with name search migh result in inconsistent
// Search only for solution in provides and files. Use buildrequire with name search might result in inconsistent
// behavior with installing dependencies of RPMs
libdnf5::GoalJobSettings settings;
settings.with_nevra = false;
Expand Down
2 changes: 1 addition & 1 deletion dnf5-plugins/builddep_plugin/po/cs.po
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2023-12-19 02:52+0000\n"
"POT-Creation-Date: 2024-01-09 02:52+0000\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <[email protected]>\n"
Expand Down
2 changes: 1 addition & 1 deletion dnf5-plugins/builddep_plugin/po/ka.po
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2023-12-19 02:52+0000\n"
"POT-Creation-Date: 2024-01-09 02:52+0000\n"
"PO-Revision-Date: 2023-11-28 02:51+0000\n"
"Last-Translator: Temuri Doghonadze <[email protected]>\n"
"Language-Team: Georgian <https://translate.fedoraproject.org/projects/dnf5/"
Expand Down
26 changes: 26 additions & 0 deletions dnf5-plugins/builddep_plugin/po/sv.po
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# SOME DESCRIPTIVE TITLE.
# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
# This file is distributed under the same license as the PACKAGE package.
# Rafael Fontenelle <[email protected]>, 2024.
msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2024-01-09 02:52+0000\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: Automatically generated\n"
"Language-Team: none\n"
"Language: sv\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"

#: builddep.cpp:84
msgid ""
"Invalid value for macro definition \"{}\". \"macro expr\" format expected."
msgstr ""

#. failed to parse some of inputs (invalid spec, no package matched...)
#: builddep.cpp:266
msgid "Failed to parse some inputs."
msgstr ""
2 changes: 1 addition & 1 deletion dnf5-plugins/changelog_plugin/po/cs.po
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2023-12-19 02:52+0000\n"
"POT-Creation-Date: 2024-01-09 02:52+0000\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <[email protected]>\n"
Expand Down
2 changes: 1 addition & 1 deletion dnf5-plugins/changelog_plugin/po/ka.po
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2023-12-19 02:52+0000\n"
"POT-Creation-Date: 2024-01-09 02:52+0000\n"
"PO-Revision-Date: 2023-11-28 02:51+0000\n"
"Last-Translator: Temuri Doghonadze <[email protected]>\n"
"Language-Team: Georgian <https://translate.fedoraproject.org/projects/dnf5/"
Expand Down
21 changes: 21 additions & 0 deletions dnf5-plugins/changelog_plugin/po/sv.po
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# SOME DESCRIPTIVE TITLE.
# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
# This file is distributed under the same license as the PACKAGE package.
# Luna Jernberg <[email protected]>, 2024.
msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2024-01-09 02:52+0000\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: Automatically generated\n"
"Language-Team: none\n"
"Language: sv\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"

#: changelog.cpp:60
msgid ""
"Invalid date passed: \"{}\". Dates in \"YYYY-MM-DD\" format are expected"
msgstr ""
3 changes: 2 additions & 1 deletion dnf5-plugins/config-manager_plugin/addrepo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,8 @@ void ConfigManagerAddRepoCommand::set_argument_parser() {
const char * value) {
auto val = strchr(value + 1, '=');
if (!val) {
throw cli::ArgumentParserError(M_("set: Badly formatted argument value \"{}\""), std::string{value});
throw cli::ArgumentParserError(
M_("{}: Badly formatted argument value \"{}\""), std::string{"set"}, std::string{value});
}
std::string key{value, val};
std::string key_value{val + 1};
Expand Down
2 changes: 1 addition & 1 deletion dnf5-plugins/config-manager_plugin/addrepo.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class ConfigManagerAddRepoCommand : public Command {

/// Tests if the repositories IDs in the vector do not already exist in the configuration.
/// @param repo_ids List of repositories IDs to check.
/// @param ignore_path The file in this path will be ignored/skiped.
/// @param ignore_path The file in this path will be ignored/skipped.
/// @throws ConfigManagerError Trown if an already existent repository ID was found.
void test_if_ids_not_already_exist(
const std::vector<std::string> & repo_ids, const std::filesystem::path & ignore_path) const;
Expand Down
2 changes: 1 addition & 1 deletion dnf5-plugins/config-manager_plugin/po/cs.po
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2023-12-19 02:52+0000\n"
"POT-Creation-Date: 2024-01-09 02:52+0000\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <[email protected]>\n"
Expand Down
2 changes: 1 addition & 1 deletion dnf5-plugins/config-manager_plugin/po/ka.po
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2023-12-19 02:52+0000\n"
"POT-Creation-Date: 2024-01-09 02:52+0000\n"
"PO-Revision-Date: 2023-11-28 02:51+0000\n"
"Last-Translator: Temuri Doghonadze <[email protected]>\n"
"Language-Team: Georgian <https://translate.fedoraproject.org/projects/dnf5/"
Expand Down
Loading
Loading