Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needs-restarting: get systemd boot time from UnitsLoadStartTimestamp #1198

Merged
merged 1 commit into from
Jan 24, 2024
Merged

needs-restarting: get systemd boot time from UnitsLoadStartTimestamp #1198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions dnf5-plugins/needs_restarting_plugin/needs_restarting.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,11 @@ void NeedsRestartingCommand::configure() {
time_t NeedsRestartingCommand::get_boot_time(Context & ctx) {
// We have three sources from which to derive the boot time. These values
// vary depending on containerization, existing of a Real Time Clock, etc:
// - UserspaceTimestamp property on /org/freedesktop/systemd1
// - UnitsLoadStartTimestamp property on /org/freedesktop/systemd1
// The start time of the service manager, according to systemd itself.
// Works unless the system was not booted with systemd, such as in (most)
// containers.
// Seems to be more reliable than UserspaceTimestamp when the RTC is
// in local time. Works unless the system was not booted with systemd,
// such as in (most) containers.
// - st_mtime of /proc/1
// Reflects the time the first process was run after booting. This
// works for all known cases except (1) machines without a RTC---they
Expand All @@ -118,7 +119,7 @@ time_t NeedsRestartingCommand::get_boot_time(Context & ctx) {
auto proxy = sdbus::createProxy(SYSTEMD_DESTINATION_NAME, SYSTEMD_OBJECT_PATH);

const uint64_t systemd_boot_time_us =
proxy->getProperty("UserspaceTimestamp").onInterface(SYSTEMD_MANAGER_INTERFACE);
proxy->getProperty("UnitsLoadStartTimestamp").onInterface(SYSTEMD_MANAGER_INTERFACE);

const time_t systemd_boot_time = static_cast<long>(systemd_boot_time_us) / (1000L * 1000L);

Expand Down
Loading