Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve goal according to strict setting first #1416

Closed
wants to merge 1 commit into from

Conversation

j-mracek
Copy link
Contributor

It should help to force solver to prefer latest solution rather then minimalistic solution skipping something.

Performance improvement for operation that does not generate any problem, because transaction is resolved only once with strict setting.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=2272257

It should help to force solver to prefer latest solution rather
then minimalistic solution skipping something.

Performance improvement for operation that does not generate
any problem, because transaction is resolved only once with
strict setting.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=2272257
Copy link
Member

@m-blaha m-blaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@m-blaha
Copy link
Member

m-blaha commented Apr 18, 2024

Hm, it looks like some tests are failing - e.g. if you try to install already installed package name and newer version is available, the result is upgrade instead of "nothing to do".

Copy link
Member

@m-blaha m-blaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several failing tests.

@j-mracek j-mracek added the blocked Further work on issue or PR is blocked by something else label Apr 18, 2024
@j-mracek
Copy link
Contributor Author

j-mracek commented Apr 18, 2024

There is a significant problem with the patch. It will force to upgrade packages to latest - when installed version is a-1-1.noarch and available is a-2-1.noarch then even dnf install a --nobest will result in upgrade of a to a-2-1.noarch. Somehow I have a problem with this behavior. What do you think?

@j-mracek
Copy link
Contributor Author

Closing the PR, because the new behavior will make no-best option useless and will trigger upgrades in situation when request should be satisfied by installed version.

@j-mracek j-mracek closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Further work on issue or PR is blocked by something else
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants