Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: the dnf5 copr enable sets CoprRepoPart.enabled = true #1461

Merged

Conversation

praiskup
Copy link
Member

This was the last occurrence causing the attribute to remain uninitialized after calling any of the constructors.

This also reverts commit 2b6b53f.

Fixes: #1317

This was the last occurrence causing the attribute to remain
uninitialized after calling any of the constructors.

This also reverts commit 2b6b53f.

Fixes: rpm-software-management#1317
@praiskup
Copy link
Member Author

The builds seem to finish, including this check:

      Start 15: test_copr
15/15 Test #15: test_copr ...................................................   Passed    0.03 sec

So I suppose the CI failures are not related to this commit.

@ppisar ppisar self-assigned this Apr 30, 2024
Copy link
Contributor

@ppisar ppisar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@ppisar ppisar added this pull request to the merge queue Apr 30, 2024
Merged via the queue into rpm-software-management:main with commit d1c1ceb Apr 30, 2024
13 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnf5 copr_plugin: Unit test failed. Probably unitialized variable (class member) in code
2 participants