Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: the dnf5 copr enable sets CoprRepoPart.enabled = true #1461

Merged
merged 1 commit into from
Apr 30, 2024
Merged

copr: the dnf5 copr enable sets CoprRepoPart.enabled = true #1461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dnf5-plugins/copr_plugin/copr_repo.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ class CoprRepoPart {
/// also the CoprRepoPart::load_raw_values() or
/// CoprRepoPart::CoprRepoPart(dnfRepo) which are more about the
/// 'disable' part.

// Copr Frontend API-responds to us with this particular CoprRepoPart
// included, so it _is_ supposed to be enabled (otherwise it would not
// be listed).
enabled = true;

if (!json->has_key("opts"))
return;
auto opts = json->get_dict_item("opts");
Expand Down
6 changes: 1 addition & 5 deletions test/dnf5-plugins/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1 @@
# Temporarily disable Copr unit tests until the plugin is fixed.
# The Copr dnf5 plug-in is broken. It uses an uninitialized variable. Because of the random value
# of this variable, unit tests fail randomly (if it has a value of 0, which is always the case when we allow
# the compiler to initialize memory to 0 or use clang).
#add_subdirectory(copr_plugin)
add_subdirectory(copr_plugin)
Loading