Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Unwind "No {} to remove for argument: {}" #1472

Merged

Conversation

ppisar
Copy link
Contributor

@ppisar ppisar commented May 7, 2024

In some languages a correct translation of that message depends on the first argument ("No {}"). This patch removes that argument by spelling all four possible values in full text.

Fixes: #1471

In some languages a correct translation of that message depends on the
first argument ("No {}"). This patch removes that argument by spelling
all four possible values in full text.

Fixes: rpm-software-management#1471
@ppisar ppisar force-pushed the i18n_no_to_remove_message branch from f6c3cff to cf7bfbb Compare May 7, 2024 12:35
@m-blaha m-blaha self-assigned this May 13, 2024
Copy link
Member

@m-blaha m-blaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@m-blaha m-blaha added this pull request to the merge queue May 13, 2024
Merged via the queue into rpm-software-management:main with commit 1e94648 May 13, 2024
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String should be split into multiple strings for l10n
2 participants