Implement conditional compilation -DWITH_MODULEMD=OFF
#1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
force-pushed
the
module-no-compile
branch
11 times, most recently
from
fb4bc89 to
a5f5135
Compare
jan-kolarik
reviewed
Jun 12, 2024
kontura
force-pushed
the
module-no-compile
branch
2 times, most recently
from
ea7ee4d to
0a0b5e8
Compare
kontura
force-pushed
the
module-no-compile
branch
from
0a0b5e8 to
8a65cc2
Compare
When WITH_MODULEMD is turned off module sources are not compiled and module headers are not installed. Public API in non-module headers (base.hpp and goal.hpp) is still available but throws an exception when used. Another option would be to also hide the functions in non-module headers but in order to ensure the headers always match the compiled library (so they don't depend on the user not defining `WITH_MODULEMD`) they would have to be configured via a constant at compile time. For example using cmake to `configure_file` turning them into `.in` files.
kontura
force-pushed
the
module-no-compile
branch
from
8a65cc2 to
a0970be
Compare
jan-kolarik
approved these changes
Jul 1, 2024
Merged
via the queue into
rpm-software-management:main
with commit Jul 1, 2024
97c295d
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: #1031
It also adds a copr build packit job to build with modules disabled to ensure the build keeps working.