Skip to content

Commit 218b74d

Browse files
Merge pull request #372 from rsagroup/measurements-copy
Fix a bug which could mutate a dataset when computing a covariance matrix
2 parents 8645f34 + 0571b4d commit 218b74d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: src/rsatoolbox/data/noise.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ def cov_from_unbalanced(dataset, obs_desc, dof=None, method='shrinkage_diag'):
389389
assert "Dataset" in str(type(dataset)), "Provided object is not a dataset"
390390
assert obs_desc in dataset.obs_descriptors.keys(), \
391391
"obs_desc not contained in the dataset's obs_descriptors"
392-
matrix = dataset.measurements
392+
matrix = dataset.measurements.copy()
393393
means, values, _ = average_dataset_by(dataset, obs_desc)
394394
values, inverse = get_unique_inverse(dataset.obs_descriptors[obs_desc])
395395
matrix -= means[inverse]

0 commit comments

Comments
 (0)