ValueErrors instead of general Exceptions

Author: HeikoSchuett

src/rsatoolbox/vis/model_plot.py

@@ -264,9 +264,10 @@ def plot_model_comparison(result, sort=False, colors=None,
         models = [models[i] for i in idx]
         if not ('descend' in sort.lower() or
                 'ascend' in sort.lower()):
-            raise Exception('plot_model_comparison: Argument ' +
-                            'sort is incorrectly defined as '
-                            + sort + '.')
+            raise ValueError(
+                'plot_model_comparison: Argument ' +
+                'sort is incorrectly defined as ' +
+                sort + '.')
 
     # run tests
     if any([test_pair_comparisons,
@@ -290,9 +291,10 @@ def plot_model_comparison(result, sort=False, colors=None,
         elif 'nili' in test_pair_comparisons.lower():
             h_pair_tests = 0.4
         else:
-            raise Exception('plot_model_comparison: Argument ' +
-                            'test_pair_comparisons is incorrectly defined as '
-                            + test_pair_comparisons + '.')
+            raise ValueError(
+                'plot_model_comparison: Argument ' +
+                'test_pair_comparisons is incorrectly defined as ' +
+                test_pair_comparisons + '.')
         ax = plt.axes((l, b, w, h*(1-h_pair_tests)))
         axbar = plt.axes((l, b + h * (1 - h_pair_tests), w,
                           h * h_pair_tests * 0.7))
@@ -359,7 +361,7 @@ def plot_model_comparison(result, sort=False, colors=None,
                     marker=10, markersize=half_sym_size,
                     linewidth=0)
         else:
-            raise Exception(
+            raise ValueError(
                 'plot_model_comparison: Argument test_above_0' +
                 ' is incorrectly defined as ' + test_above_0 + '.')
 
@@ -396,7 +398,7 @@ def plot_model_comparison(result, sort=False, colors=None,
                     markerfacecolor=noise_ceil_col,
                     markeredgecolor='none', linewidth=0)
         else:
-            raise Exception(
+            raise ValueError(
                 'plot_model_comparison: Argument ' +
                 'test_below_noise_ceil is incorrectly defined as ' +
                 test_below_noise_ceil + '.')
@@ -908,7 +910,7 @@ def _get_model_comp_descr(test_type, n_models, multiple_pair_testing, alpha,
                             ' model-pair comparisons)')
     else:
         if 'uncorrected' not in multiple_pair_testing.lower():
-            raise Exception(
+            raise ValueError(
                 'plot_model_comparison: Argument ' +
                 'multiple_pair_testing is incorrectly defined as ' +
                 multiple_pair_testing + '.')