Sweep rescue nil cleanup paths across remaining specs

Continues the cleanup begun in PR #2687. The previous PR replaced
`@conn.execute "DROP …" rescue nil` in `connection_spec.rb` with
`drop_table` / `drop_if_exists`, narrowing the rescue to the per-kind
"object does not exist" ORA codes so privilege failures, ORA-00972
identifier-too-long on 11g, syntax errors, etc. propagate instead of
being silently absorbed.

This sweep covers the remaining spec files that used the same
pattern:

  oracle_enhanced_data_types_spec.rb
  oracle_enhanced/context_index_spec.rb
  oracle_enhanced/dbms_metadata_structure_dump_spec.rb
  oracle_enhanced/quoting_spec.rb
  oracle_enhanced/schema_dumper_spec.rb
  oracle_enhanced/schema_statements_spec.rb
  oracle_enhanced/structure_dump_spec.rb

The replacements follow the same per-call-site review used in #2687:

  - DROP TABLE (+ implicit default `<table>_seq`) → `drop_table(name,
    if_exists: true)`. The standard ActiveRecord public API also
    cleans up the default sequence, so the explicit DROP SEQUENCE
    line in `oracle_enhanced_data_types_spec.rb` is redundant and
    drops out.
  - DROP <other-object> (VIEW, MATERIALIZED VIEW, SYNONYM, PACKAGE,
    FUNCTION, PROCEDURE, TYPE, TRIGGER, SEQUENCE) →
    `drop_if_exists("<TYPE>", name)`.
  - `remove_foreign_key … rescue nil` → `remove_foreign_key …,
    if_exists: true` (already supported by AR).
  - `Object.send(:remove_const, "X") rescue nil` →
    `Object.send(:remove_const, "X") if Object.const_defined?("X")`.

`structure_dump_spec.rb`'s `after(:each)` had a long pile of
`ALTER TABLE … DROP CONSTRAINT` and `ALTER TABLE … DROP COLUMN`
lines, also wrapped in `rescue nil`. They were redundant: every
constraint and column they removed was on `test_posts` or `foos`,
both of which the same hook drops a few lines later — the
constraints and columns disappear with their parent table. A few of
the names (`UK_FOOZ_BAZ`, `fooz_id`) were not even created by any
test in the file. Simplified to a flat sequence of
view/table/sequence/trigger/type drops in dependency order.

For `remove_context_index`, ActiveRecord has no equivalent helper, so
this commit also extends the Oracle-Enhanced adapter helper itself to
accept `if_exists:`. `remove_context_index(name:, if_exists: true)`
now calls `drop_if_exists("INDEX", index_name, if_exists: …)`
internally and routes the auxiliary trigger / procedure cleanup
through `drop_if_exists` too (replacing the inline `rescue nil`
those private helpers had themselves). The auxiliary
`drop_ctx_preference` PL/SQL call is left as-is for now — Oracle
Text returns DRG-* codes, not ORA-*, and narrowing it requires a
separate per-code audit.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: yahonda

lib/active_record/connection_adapters/oracle_enhanced/context_index.rb

@@ -126,18 +126,21 @@ def add_context_index(table_name, column_name, options = {})
           execute sql
         end
 
-        # Drop full text index with Oracle specific CONTEXT index type
+        # Drop full text index with Oracle specific CONTEXT index type.
+        # Pass `if_exists: true` to tolerate the index already being absent
+        # (rescues only ORA-01418 "specified index does not exist").
         def remove_context_index(table_name, options = {})
           unless Hash === options # if column names passed as argument
             options = { column: Array(options) }
           end
+          if_exists = options[:if_exists]
           index_name = options[:name] || index_name(table_name,
             column: options[:index_column] || options[:column], identifier_max_length: 25)
-          execute "DROP INDEX #{index_name}"
+          drop_if_exists("INDEX", index_name, if_exists: if_exists)
           drop_ctx_preference(default_datastore_name(index_name))
           drop_ctx_preference(default_storage_name(index_name))
           procedure_name = default_datastore_procedure(index_name)
-          execute "DROP PROCEDURE #{quote_table_name(procedure_name)}" rescue nil
+          drop_if_exists("PROCEDURE", procedure_name, if_exists: true)
           drop_index_column_trigger(index_name)
         end
 
@@ -291,7 +294,7 @@ def create_index_column_trigger(table_name, index_name, index_column, index_colu
 
           def drop_index_column_trigger(index_name)
             trigger_name = default_index_column_trigger_name(index_name)
-            execute "DROP TRIGGER #{quote_table_name(trigger_name)}" rescue nil
+            drop_if_exists("TRIGGER", trigger_name, if_exists: true)
           end
 
           def default_datastore_procedure(index_name)

spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb

@@ -204,8 +204,8 @@ class ::Comment < ActiveRecord::Base
     end
 
     after(:each) do
-      @conn.remove_context_index :posts, name: "post_and_comments_index" rescue nil
-      @conn.remove_context_index :posts, index_column: :all_text rescue nil
+      @conn.remove_context_index :posts, name: "post_and_comments_index", if_exists: true
+      @conn.remove_context_index :posts, index_column: :all_text, if_exists: true
       Post.destroy_all
     end
 

spec/active_record/connection_adapters/oracle_enhanced/dbms_metadata_structure_dump_spec.rb

@@ -178,11 +178,11 @@
   describe "structure_dump_db_stored_code (DBMS_METADATA path)" do
     before(:each) do
       skip "requires Oracle 12.1+ for the DBMS_METADATA path" unless @conn.use_dbms_metadata_dump?
-      @conn.execute "DROP PACKAGE test_dbms_metadata_pkg" rescue nil
+      @conn.drop_if_exists("PACKAGE", "test_dbms_metadata_pkg")
     end
 
     after(:each) do
-      @conn.execute "DROP PACKAGE test_dbms_metadata_pkg" rescue nil
+      @conn.drop_if_exists("PACKAGE", "test_dbms_metadata_pkg")
     end
 
     it "emits a PACKAGE BODY only once" do

spec/active_record/connection_adapters/oracle_enhanced/quoting_spec.rb

@@ -200,8 +200,8 @@ def create_camel_case_table
           drop_table "CamelCase", if_exists: true
         end
       end
-      Object.send(:remove_const, "WarehouseThing") rescue nil
-      Object.send(:remove_const, "CamelCase") rescue nil
+      Object.send(:remove_const, "WarehouseThing") if Object.const_defined?("WarehouseThing")
+      Object.send(:remove_const, "CamelCase") if Object.const_defined?("CamelCase")
     end
 
     it "should allow creation of a table with non alphanumeric characters" do

spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb

@@ -130,8 +130,8 @@ def drop_test_posts_table
 
     after(:each) do
       schema_define do
-        remove_foreign_key :test_comments, :test_posts rescue nil
-        remove_foreign_key :test_comments, name: "comments_posts_baz_fooz_fk" rescue nil
+        remove_foreign_key :test_comments, :test_posts, if_exists: true
+        remove_foreign_key :test_comments, name: "comments_posts_baz_fooz_fk", if_exists: true
       end
     end
 
@@ -326,7 +326,7 @@ def drop_test_posts_table
 
   describe "materialized views" do
     after(:each) do
-      @conn.execute "DROP MATERIALIZED VIEW test_posts_mv" rescue nil
+      @conn.drop_if_exists("MATERIALIZED VIEW", "test_posts_mv")
       drop_test_posts_table
     end
 

spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb

@@ -1459,7 +1459,7 @@ class ::TestEmployee < ActiveRecord::Base; end
     end
 
     after(:all) do
-      @conn.execute("drop materialized view sum_test_employees") rescue nil
+      @conn.drop_if_exists("MATERIALIZED VIEW", "sum_test_employees")
       schema_define do
         drop_table :sum_test_employees, if_exists: true
         drop_table :test_employees, if_exists: true

spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb

@@ -36,21 +36,14 @@ class ::TestPost < ActiveRecord::Base
     end
 
     after(:each) do
+      @conn.drop_if_exists("VIEW", "test_posts_view_a")
+      @conn.drop_if_exists("VIEW", "test_posts_view_z")
       @conn.drop_table :test_posts
       @conn.drop_table :foos
-      @conn.execute "DROP SEQUENCE test_posts_seq" rescue nil
-      @conn.execute "ALTER TABLE test_posts drop CONSTRAINT fk_test_post_foo" rescue nil
-      @conn.execute "DROP TRIGGER test_post_trigger" rescue nil
-      @conn.execute "DROP TYPE TEST_TYPE" rescue nil
-      @conn.execute "DROP TABLE bars" rescue nil
-      @conn.execute "ALTER TABLE foos drop CONSTRAINT UK_BAZ" rescue nil
-      @conn.execute "ALTER TABLE foos drop CONSTRAINT UK_FOOZ_BAZ" rescue nil
-      @conn.execute "ALTER TABLE foos drop column fooz_id" rescue nil
-      @conn.execute "ALTER TABLE foos drop column baz_id" rescue nil
-      @conn.execute "ALTER TABLE test_posts drop column fooz_id" rescue nil
-      @conn.execute "ALTER TABLE test_posts drop column baz_id" rescue nil
-      @conn.execute "DROP VIEW test_posts_view_z" rescue nil
-      @conn.execute "DROP VIEW test_posts_view_a" rescue nil
+      @conn.drop_table :bars, if_exists: true
+      @conn.drop_if_exists("SEQUENCE", "test_posts_seq")
+      @conn.drop_if_exists("TRIGGER", "test_post_trigger")
+      @conn.drop_if_exists("TYPE", "TEST_TYPE")
       Object.send(:remove_const, "TestPost") if defined?(TestPost)
       ActiveRecord::Base.clear_cache!
     end
@@ -470,15 +463,15 @@ class ::TestPost < ActiveRecord::Base
     end
 
     after(:each) do
+      @conn.drop_if_exists("VIEW", "full_drop_test_view")
+      @conn.drop_if_exists("MATERIALIZED VIEW", "full_drop_test_mview")
+      @conn.drop_if_exists("SYNONYM", "full_drop_test_synonym")
+      @conn.drop_if_exists("PACKAGE", "full_drop_test_package")
+      @conn.drop_if_exists("FUNCTION", "full_drop_test_function")
+      @conn.drop_if_exists("PROCEDURE", "full_drop_test_procedure")
+      @conn.drop_if_exists("TYPE", "full_drop_test_type")
       @conn.drop_table :full_drop_test
       @conn.drop_table :full_drop_test_temp
-      @conn.execute "DROP VIEW FULL_DROP_TEST_VIEW" rescue nil
-      @conn.execute "DROP MATERIALIZED VIEW FULL_DROP_TEST_MVIEW" rescue nil
-      @conn.execute "DROP SYNONYM FULL_DROP_TEST_SYNONYM" rescue nil
-      @conn.execute "DROP PACKAGE FULL_DROP_TEST_PACKAGE" rescue nil
-      @conn.execute "DROP FUNCTION FULL_DROP_TEST_FUNCTION" rescue nil
-      @conn.execute "DROP PROCEDURE FULL_DROP_TEST_PROCEDURE" rescue nil
-      @conn.execute "DROP TYPE FULL_DROP_TEST_TYPE" rescue nil
     end
 
     it "should contain correct sql" do
@@ -540,7 +533,7 @@ def test_identity_dump_block(dump)
     end
 
     after do
-      @conn.execute("DROP SYNONYM test_synonym") rescue nil
+      @conn.drop_if_exists("SYNONYM", "test_synonym")
       @conn.drop_table :test_synonym_target, if_exists: true
     end
 

spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb

@@ -4,8 +4,7 @@
   before(:all) do
     ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
     @conn = ActiveRecord::Base.lease_connection
-    @conn.execute "DROP TABLE test_employees" rescue nil
-    @conn.execute "DROP SEQUENCE test_employees_seq" rescue nil
+    @conn.drop_table "test_employees", if_exists: true
     @conn.execute <<~SQL
       CREATE TABLE test_employees (
         employee_id   NUMBER(6,0) PRIMARY KEY,