workaround deserialize on save - rails/rails#44317

Author: akostadinov

lib/active_record/type/oracle_enhanced/raw.rb

@@ -10,13 +10,21 @@ def type
           :raw
         end
 
+        # see ActiveModel::ActiveModel#forget_attribute_assignments
+        # workaround for https://github.com/rails/rails/issues/44317
+        def deserialize(value)
+          value.respond_to?(:enhanced_deserialized) ? value.enhanced_deserialized : super
+        end
+
         def serialize(value)
           # Encode a string or byte array as string of hex codes
           if value.nil?
             super
           else
-            value = value.unpack("C*")
-            value.map { |x| "%02X" % x }.join
+            value.unpack("C*").map { |x| "%02X" % x }.join.tap do |serialized|
+              serialized.singleton_class.attr_accessor :enhanced_deserialized
+              serialized.enhanced_deserialized = value
+            end
           end
         end
       end

spec/active_record/oracle_enhanced/type/raw_spec.rb

@@ -12,7 +12,7 @@
         t.raw       :binary_data,   limit: 1024
       end
     end
-    @binary_data = "\0\1\2\3\4\5\6\7\8\9" * 100
+    @binary_data = ("\0\1\2\3\4\5\6\7\8\9" * 100).freeze
     @binary_data2 = "\1\2\3\4\5\6\7\8\9\0" * 100
   end
 
@@ -38,6 +38,7 @@ class ::TestEmployee < ActiveRecord::Base
       last_name: "Last",
       binary_data: @binary_data
     )
+    expect(@employee.binary_data).to eq(@binary_data)
     @employee.reload
     expect(@employee.binary_data).to eq(@binary_data)
   end
@@ -51,6 +52,7 @@ class ::TestEmployee < ActiveRecord::Base
     expect(@employee.binary_data).to be_nil
     @employee.binary_data = @binary_data
     @employee.save!
+    expect(@employee.binary_data).to eq(@binary_data)
     @employee.reload
     expect(@employee.binary_data).to eq(@binary_data)
   end
@@ -77,6 +79,7 @@ class ::TestEmployee < ActiveRecord::Base
     @employee.reload
     @employee.binary_data = @binary_data2
     @employee.save!
+    expect(@employee.binary_data).to eq(@binary_data2)
     @employee.reload
     expect(@employee.binary_data).to eq(@binary_data2)
   end
@@ -116,13 +119,14 @@ class ::TestEmployee < ActiveRecord::Base
     @employee.reload
     @employee.binary_data = @binary_data
     @employee.save!
+    expect(@employee.binary_data).to eq(@binary_data)
     @employee.reload
     expect(@employee.binary_data).to eq(@binary_data)
   end
 
   it "should allow equality on select" do
     TestEmployee.delete_all
-    TestEmployee.create!(
+    employee = TestEmployee.create!(
       first_name: "First",
       last_name: "Last",
       binary_data: @binary_data,
@@ -132,6 +136,20 @@ class ::TestEmployee < ActiveRecord::Base
       last_name: "Last1",
       binary_data: @binary_data2,
     )
-    expect(TestEmployee.where(binary_data: @binary_data)).to have_attributes(count: 1)
+    expect(TestEmployee.where(binary_data: @binary_data).to_a).to eq([employee])
+  end
+
+  it "should allow equality on select with NULL value" do
+    TestEmployee.delete_all
+    employee = TestEmployee.create!(
+      first_name: "First",
+      last_name: "Last",
+      )
+    TestEmployee.create!(
+      first_name: "First1",
+      last_name: "Last1",
+      binary_data: @binary_data2,
+      )
+    expect(TestEmployee.where(binary_data: nil).to_a).to eq([employee])
   end
 end