Merge pull request #2593 from yahonda/backport-2592-to-release81

Backport #2592 to release81: Use default_sequence_name to identify sequence when renaming a table

Author: yahonda

lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb

@@ -259,7 +259,7 @@ def rename_table(table_name, new_name, **options) # :nodoc:
           schema_cache.clear_data_source_cache!(table_name.to_s)
           schema_cache.clear_data_source_cache!(new_name.to_s)
           execute "RENAME #{quote_table_name(table_name)} TO #{quote_table_name(new_name)}"
-          execute "RENAME #{quote_table_name("#{table_name}_seq")} TO #{default_sequence_name(new_name)}" rescue nil
+          execute "RENAME #{default_sequence_name(table_name)} TO #{default_sequence_name(new_name)}" rescue nil
 
           rename_table_indexes(table_name, new_name, **options)
         end

spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb

@@ -296,13 +296,15 @@ class ::TestEmployee < ActiveRecord::Base; end
     end
 
     after(:each) do
+      long_name = ("a" * (@conn.sequence_name_length - 3)).to_sym
       schema_define do
         drop_table :test_employees_no_primary_key, if_exists: true
         drop_table :test_employees, if_exists: true
         drop_table :new_test_employees, if_exists: true
         drop_table :test_employees_no_pkey, if_exists: true
         drop_table :new_test_employees_no_pkey, if_exists: true
         drop_table :aaaaaaaaaaaaaaaaaaaaaaaaaaa, if_exists: true
+        drop_table long_name, if_exists: true
       end
     end
 
@@ -329,6 +331,26 @@ class ::TestEmployee < ActiveRecord::Base; end
         @conn.rename_table("test_employees_no_pkey", "new_test_employees_no_pkey")
       end.not_to raise_error
     end
+
+    it "renames the auto-generated sequence when the source table name is long enough to truncate it" do
+      long_source = "a" * (@conn.sequence_name_length - 3)
+      schema_define do
+        create_table long_source.to_sym, force: true do |t|
+          t.string :first_name
+        end
+      end
+
+      expected_old_seq = @conn.default_sequence_name(long_source).upcase
+      expected_new_seq = @conn.default_sequence_name("new_test_employees").upcase
+
+      @conn.rename_table(long_source, "new_test_employees")
+
+      sequences = @conn.select_values(
+        "SELECT sequence_name FROM user_sequences WHERE sequence_name IN ('#{expected_old_seq}', '#{expected_new_seq}')"
+      )
+      expect(sequences).to include(expected_new_seq)
+      expect(sequences).not_to include(expected_old_seq)
+    end
   end
 
   describe "add index" do