Getting primary key with RETURNING INTO doesn't work in Rails 7 and later

[cmcfadden]

We're updating a Rails 6.1 application to 7.1. We're running into an issue with a table that has a trigger to generate a primary key on insert, which should be populated back into the model using RETURNING INTO.

We're finding that that's not working, due to the checks for the primary key type in sql_for_insert.

Our model defines primary key as:
self.primary_key = :rid

By the time the sql_for_insert method is invoked though, pk is of type String, so this code never inserts the RETURNING INTO sql.

It seems like this was a change (the check for pk being a string) introduced with the move to 7, but I can't find incidents of other people encountering an issue here. Anyone have thoughts?

[TheSynthMaster]

Same as my 2431. No one is taking care of this.

I have put in place a workaround if you are interested.

[cmcfadden]

@TheSynthMaster I looked at yours, but in our case we're not using sequences so we ended up just tweaking the check around primary key being a string.

[TheSynthMaster]

Oh... maybe it's also my problem, in the past the primary had to be an integer, maybe at some point they changed this, I will give it a try

[akostadinov]

I didn't look into this issue bu could it be related to
rails/rails#55401
be44216

There were some changes since Rails is trying to support composite primary keys.