I'm facing some issues when this method is called (OracleEnhancedAdapter#columns_for_distinct(columns, orders)) with Rails 8.0.4.
In particual the two issues I see are:
- Since Rails 7.1 added support for composite primary keys the first attribute is (can be) a list of columns which is interpolated as is into the SQL query resulting in invalid syntax
- It's not stripping out "NULLS FIRST" or "NULLS LAST" from the order by clauses, also resulting in invalid syntax
I think the first issue can be solved by joinin columns by a comma and the latter by copying postgres' solution.
I can create a PR later when I have time.
I'm facing some issues when this method is called (
OracleEnhancedAdapter#columns_for_distinct(columns, orders)) with Rails 8.0.4.In particual the two issues I see are:
I think the first issue can be solved by joinin columns by a comma and the latter by copying postgres' solution.
I can create a PR later when I have time.